Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1688113002: Devtools: Add device frames to device mode (Closed)

Created:
4 years, 10 months ago by samli
Modified:
4 years, 9 months ago
Reviewers:
paulirish, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Add device frames to device mode Adds device frame option which is enabled by default. As devices have a fixed size, rulers are updated to only show the constrained size.

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Messages

Total messages: 5 (3 generated)
samli
Screenshots: (http://imgur.com/a/6CrQm) dgozman@: PTAL at code. Images are not included since I'm not sure we ...
4 years, 10 months ago (2016-02-11 04:39:25 UTC) #4
dgozman
4 years, 10 months ago (2016-02-11 18:23:34 UTC) #5
mmccoy@ is already working on this: https://codereview.chromium.org/1650243004/.
Could you please collaborate?

Powered by Google App Engine
This is Rietveld 408576698