Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1688103002: Revert of Native SSID extraction moved to platform code on Android (Closed)

Created:
4 years, 10 months ago by mdjones
Modified:
4 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Native SSID extraction moved to platform code on Android (patchset #8 id:140001 of https://codereview.chromium.org/1633733005/ ) Reason for revert: Causes instant crash on Android KK, L, and M. Original issue's description: > On Android, move Wifi SSID extraction to a Java implementation > > On some Android devices, the device will restart right > after the browser is launched. This is due to a kernel bug on > these devices when using the Linux GetWifiSSID implementation, > which causes a kernel panic and device restart. > > To avoid this, a Java-based implementation is used for Android > devices, which avoids this. Examples of affected devices include: > HTC One S > Lenovo A820 > Asus ZenFone 2 > MediaPad 10 FHD > > R=bengr@chromium.org,rch@chromium.org > BUG=555067 > TEST=Take the problem device, install browser and start it, wait for > 10 seconds. Make 10 experiments, cleaning data before each run. > Device should not reboot. TBR=bengr@chromium.org,rch@chromium.org,rsleevi@chromium.org,ripp@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555067 Committed: https://crrev.com/338a3bb9656e66896c4b28dc08a24c28579ee5f5 Cr-Commit-Position: refs/heads/master@{#374833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 2 chunks +0 lines, -32 lines 0 comments Download
M net/android/network_library.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/android/network_library.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/android/unittest_support/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
D net/base/network_interfaces_android.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M net/base/network_interfaces_linux.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
mdjones
Created Revert of Native SSID extraction moved to platform code on Android
4 years, 10 months ago (2016-02-11 02:00:25 UTC) #1
Ryan Sleevi
lgtm
4 years, 10 months ago (2016-02-11 02:00:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688103002/1
4 years, 10 months ago (2016-02-11 02:04:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 02:06:43 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/338a3bb9656e66896c4b28dc08a24c28579ee5f5
Cr-Commit-Position: refs/heads/master@{#374833}

Powered by Google App Engine
This is Rietveld 408576698