chrome/chrome_common.gypi - Issue 16881004: Move chrome/nacl to components/nacl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 16881004: Move chrome/nacl to components/nacl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 785632750ebc604803019a2ce41cb2521a2c2dbd..657486a3e31bb349329e2b8e5f14bc53e568690f 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -126,7 +126,6 @@

'common/chrome_notification_types.h',

'common/chrome_result_codes.h',

'common/chrome_process_type.h',

- 'common/chrome_sandbox_type_mac.h',

'common/chrome_utility_messages.h',

'common/chrome_version_info.cc',

'common/chrome_version_info_android.cc',

@@ -374,13 +373,7 @@

'common/multi_process_lock_linux.cc',

'common/multi_process_lock_mac.cc',

'common/multi_process_lock_win.cc',

- 'common/nacl_cmd_line.cc',

- 'common/nacl_cmd_line.h',

'common/nacl_host_messages.h',

- 'common/nacl_messages.cc',

- 'common/nacl_messages.h',

- 'common/nacl_types.cc',

- 'common/nacl_types.h',

'common/omaha_query_params/omaha_query_params.cc',

'common/omaha_query_params/omaha_query_params.h',

'common/omnibox_focus_state.h',

@@ -481,6 +474,8 @@

'<(DEPTH)/chrome/app/policy/cloud_policy_codegen.gyp:policy',

'<(DEPTH)/chrome/common/extensions/api/api.gyp:api',

'<(DEPTH)/components/components.gyp:autofill_core_common',

+ '<(DEPTH)/components/nacl_common.gypi:nacl_cmd_line',

+ '<(DEPTH)/components/nacl_common.gypi:nacl_common',

'<(DEPTH)/ipc/ipc.gyp:ipc',

'<(DEPTH)/printing/printing.gyp:printing',

'<(DEPTH)/third_party/adobe/flash/flash_player.gyp:flapper_version_h',

@@ -500,7 +495,6 @@

['exclude', '^common/external_ipc_fuzzer\\.'],

['exclude', '^common/logging_chrome\\.'],

['exclude', '^common/multi_process_'],

- ['exclude', '^common/nacl_'],

['exclude', '^common/pepper_flash\\.'],

['exclude', '^common/profiling\\.'],

['exclude', '^common/service_process_util_'],

« chrome/app/chrome_main_delegate.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »