Move chrome/nacl to components/nacl.

components/nacl/common/nacl_delegate.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NACL_COMMON_NACL_DELEGATE_H_
+#define COMPONENTS_NACL_COMMON_NACL_DELEGATE_H_
+
+#include "build/build_config.h"
+
+namespace base {
+class FilePath;
+}
+
+// This class encapsulates all the dependencies that nacl has on chrome
+class NaClDelegate {
+ public:
+  enum NaClSwitch {
+    kDisableBreakpad,
+    kDisableLogging,
+    kEnableDCHECK,
+    kEnableLogging,
+    kFullMemoryCrashReport,
+    kLoggingLevel,
+    kMemoryProfiling,
+    kNaClBrokerProcess,
+    kNaClLoaderProcess,
+    kNoErrorDialogs,
+    kNoSandbox,
+    kProcessType,
+    kSilentDumpOnDCHECK,
+    kTestNaClSandbox,
+#if defined(OS_MACOSX)
+    kEnableSandboxLogging,
+#endif
+    };

[jam, 2013/06/14 23:18:53]

this is very hacky, please find a clean way of doing this

for example, components/nacl will depend on content. so it can grab the content
flags directly. then, nacl specific flags like kNaClBrokerProcess etc can move
to src/components/nacl. for whatever remains after that, the components code
shouldn't have an enum of the flags in chrome. instead, it should just tell it
"hey, i'm about to launch a process, add any flags that you want". see
ContentBrowserClient::AppendExtraCommandLineSwitches as an example

+
+    enum NaClFilePath {
+      kFileNaClHelper,
+      kFileNaClHelperBootstrap,
+    };
+
+  NaClDelegate() {}
+  ~NaClDelegate() {}
+  const char* GetSwitch(NaClSwitch switch_name);
+
+#if defined(OS_POSIX) && !defined(OS_MACOSX)
+  bool GetFilePath(NaClFilePath path, base::FilePath* file_path);
+#endif
+};
+
+extern NaClDelegate* GetNaClDelegate();
+
+#endif  // COMPONENTS_NACL_COMMON_NACL_DELEGATE_H_