Move chrome/nacl to components/nacl.

components/nacl/common/nacl_delegate.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NACL_COMMON_NACL_DELEGATE_H_
+#define COMPONENTS_NACL_COMMON_NACL_DELEGATE_H_
+
+#include "build/build_config.h"
+
+namespace base {
+class FilePath;
+}
+
+class CommandLine;
+
+// This class encapsulates all the dependencies that nacl has on chrome
+class NaClDelegate {
+ public:
+  NaClDelegate() {}
+  ~NaClDelegate() {}
+
+  // Copy all the relevant arguments from the command line of the current
+  // process to cmd_line that will be used for launching the NaCl loader/broker.
+  void CopyNaClCommandLineArguments(CommandLine* cmd_line);
+};
+
+extern NaClDelegate* GetNaClDelegate();

[jam, 2013/06/17 20:10:43]

please see other delegates for other modules for examples on how we structure
this. but the current approach isn't something that we use (i.e. declaring a
method in one module, and expecting a module higher up to implement it).

can you plumb the delegate pointer to the code that eventually needs it?

another simpler option would be to forget about passing
switches::kSilentDumpOnDCHECK,
switches::kMemoryProfiling,

to the nacl broker. these are windows only, and i'm not sure if any of the nacl
devs care about them now. i..e i'm pretty sure the second one is not used by
anyone. as for the second one, it's just a debugging utility so we don't really
need it. i don't even see any DCHECKs in the nacl broker code. if we need them
in the future, we can figure out how to do it then.

[yael.aharon1, 2013/06/18 17:16:30]

My problem here is that the only code from chrome that is used in the broker
process is breakpad_win, crash_keys and hard_error_handler_win. This makes it
very tricky for me to find a place from which I can plumb the delegate pointer. 
Is it ok to just remove these 2 switches? If I can do that, I will not need a
delegate at all.

[jam, 2013/06/19 17:55:53]

yes, i'm totally fine with not passing these two switches. one is for sure not
used by anyone afaik (memory profiling), while the other is not that important

+
+#endif  // COMPONENTS_NACL_COMMON_NACL_DELEGATE_H_