Move chrome/nacl to components/nacl.

chrome/chrome_common.gypi

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'common',
       'type': 'static_library',
       'variables': {
@@ skipping 107 matching lines @@
         'common/child_process_logging_mac.mm',
         'common/child_process_logging_posix.cc',
         'common/child_process_logging_win.cc',
         'common/chrome_content_client.cc',
         'common/chrome_content_client.h',
         'common/chrome_content_client_constants.cc',
         'common/chrome_content_client_ios.mm',
         'common/chrome_notification_types.h',
         'common/chrome_result_codes.h',
         'common/chrome_process_type.h',
-        'common/chrome_sandbox_type_mac.h',
         'common/chrome_utility_messages.h',
         'common/chrome_version_info.cc',
         'common/chrome_version_info_android.cc',
         'common/chrome_version_info_chromeos.cc',
         'common/chrome_version_info_posix.cc',
         'common/chrome_version_info_mac.mm',
         'common/chrome_version_info_win.cc',
         'common/chrome_version_info.h',
         'common/cloud_print/cloud_print_class_mac.h',
         'common/cloud_print/cloud_print_class_mac.mm',
@@ skipping 227 matching lines @@
         'common/metrics/metrics_util.cc',
         'common/metrics/metrics_util.h',
         'common/metrics/variations/uniformity_field_trials.cc',
         'common/metrics/variations/uniformity_field_trials.h',
         'common/metrics/variations/variations_util.cc',
         'common/metrics/variations/variations_util.h',
         'common/multi_process_lock.h',
         'common/multi_process_lock_linux.cc',
         'common/multi_process_lock_mac.cc',
         'common/multi_process_lock_win.cc',
-        'common/nacl_cmd_line.cc',
-        'common/nacl_cmd_line.h',
-        'common/nacl_messages.cc',
-        'common/nacl_messages.h',
-        'common/nacl_types.cc',
-        'common/nacl_types.h',
+        'common/nacl_delegate.cc',
         'common/omaha_query_params/omaha_query_params.cc',
         'common/omaha_query_params/omaha_query_params.h',
         'common/omnibox_focus_state.h',
         'common/one_click_signin_messages.h',
         'common/partial_circular_buffer.cc',
         'common/partial_circular_buffer.h',
         'common/pepper_flash.cc',
         'common/pepper_flash.h',
         'common/pepper_permission_util.cc',
         'common/pepper_permission_util.h',
@@ skipping 44 matching lines @@
         'common/tts_utterance_request.h',
         'common/url_constants.cc',
         'common/url_constants.h',
         'common/validation_message_messages.h',
         'common/web_application_info.cc',
         'common/web_application_info.h',
         'common/web_resource/web_resource_unpacker.cc',
         'common/web_resource/web_resource_unpacker.h',
         'common/worker_thread_ticker.cc',
         'common/worker_thread_ticker.h',
+        '../components/nacl/common/nacl_delegate.h',

[jam, 2013/06/17 20:10:43]

you shouldn't be listing the files from components here. they should have their
own target and you should depend on it here

[yael.aharon1, 2013/06/19 20:38:52]

Done.

+        '../components/nacl/common/nacl_messages.cc',
+        '../components/nacl/common/nacl_messages.h',
+        '../components/nacl/common/nacl_types.cc',
+        '../components/nacl/common/nacl_types.h',
       ],
       'conditions': [
         ['enable_extensions==1', {
           'sources!': [
             'common/extensions/api/extension_api_stub.cc',
           ],
           'dependencies': [
             '../device/usb/usb.gyp:device_usb',
           ],
         }, {  # enable_extensions == 0
@@ skipping 35 matching lines @@
             ['exclude', '^common/child_process_'],
             ['exclude', '^common/chrome_content_client\\.cc$'],
             ['exclude', '^common/chrome_version_info_posix\\.cc$'],
             ['exclude', '^common/common_message_generator\\.cc$'],
             ['exclude', '^common/common_param_traits'],
             ['exclude', '^common/custom_handlers/'],
             ['exclude', '^common/extensions/'],
             ['exclude', '^common/external_ipc_fuzzer\\.'],
             ['exclude', '^common/logging_chrome\\.'],
             ['exclude', '^common/multi_process_'],
-            ['exclude', '^common/nacl_'],
             ['exclude', '^common/pepper_flash\\.'],
             ['exclude', '^common/profiling\\.'],
             ['exclude', '^common/service_process_util_'],
             ['exclude', '^common/spellcheck_'],
             ['exclude', '^common/validation_message_'],
             ['exclude', '^common/web_apps\\.'],
+            ['exclude', '^../components/nacl/common/nacl_'],
             # TODO(ios): Include files here as they are made to work; once
             # everything is online, remove everything below here and just
             # use the exclusions above.
             ['exclude', '\\.(cc|mm)$'],
             ['include', '_ios\\.(cc|mm)$'],
             ['include', '(^|/)ios/'],
             ['include', '^common/chrome_version_info\\.cc$'],
             ['include', '^common/zip'],
           ],
           'include_dirs': [
@@ skipping 254 matching lines @@
         'common/metrics/proto/user_action_event.proto',
       ],
       'variables': {
         'proto_in_dir': 'common/metrics/proto',
         'proto_out_dir': 'chrome/common/metrics/proto',
       },
       'includes': [ '../build/protoc.gypi' ],
     },
   ],
 }