Chromium Code Reviews
DescriptionDevTools: [Console] fix viewport stick-to-bottom behavior
The patch fixes viewport "stick-to-bottom" behavior.
By contract, the client of ViewportControl will change amount of
viewported elements and then call ViewportControl::invalidate, signaling
to update rendered elements.
The patch changes ViewportControl::refresh method so that it doesn't
re-query elements from provider if provider's item count changes.
This corresponds with the API contract.
After that, the stick-to-bottom behavior should be taken in consideration
only for ViewportControl::invalidate calls.
BUG=580381
R=dgozman, pfeldman
Committed: https://crrev.com/e26b3a1a0f2ea3311fb990f6740c3a1d794ba5c4
Cr-Commit-Position: refs/heads/master@{#375107}
Patch Set 1 #Patch Set 2 : add a test #Patch Set 3 : #
Messages
Total messages: 14 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||