Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1688053004: DevTools: [Console] fix viewport stick-to-bottom behavior (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Console] fix viewport stick-to-bottom behavior The patch fixes viewport "stick-to-bottom" behavior. By contract, the client of ViewportControl will change amount of viewported elements and then call ViewportControl::invalidate, signaling to update rendered elements. The patch changes ViewportControl::refresh method so that it doesn't re-query elements from provider if provider's item count changes. This corresponds with the API contract. After that, the stick-to-bottom behavior should be taken in consideration only for ViewportControl::invalidate calls. BUG=580381 R=dgozman, pfeldman Committed: https://crrev.com/e26b3a1a0f2ea3311fb990f6740c3a1d794ba5c4 Cr-Commit-Position: refs/heads/master@{#375107}

Patch Set 1 #

Patch Set 2 : add a test #

Patch Set 3 : #

Messages

Total messages: 14 (5 generated)
lushnikov
зефд
4 years, 10 months ago (2016-02-11 01:00:46 UTC) #1
dgozman
let's add a test
4 years, 10 months ago (2016-02-11 01:22:01 UTC) #2
lushnikov
here comes the test
4 years, 10 months ago (2016-02-11 02:39:18 UTC) #3
dgozman
lgtm
4 years, 10 months ago (2016-02-11 18:18:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688053004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688053004/40001
4 years, 10 months ago (2016-02-11 23:04:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/179155)
4 years, 10 months ago (2016-02-12 00:57:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688053004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688053004/40001
4 years, 10 months ago (2016-02-12 02:43:00 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-12 03:18:32 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:41:15 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e26b3a1a0f2ea3311fb990f6740c3a1d794ba5c4
Cr-Commit-Position: refs/heads/master@{#375107}

Powered by Google App Engine
This is Rietveld 408576698