Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688043005: Fix SharedFunctionInfo::name flattening nosnap failures (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix SharedFunctionInfo::name flattening nosnap failures The name must be flattened before allocating the SFI to avoid the GC seeing the uninitialized state. BUG=v8:4659 LOG=n TBR=rossberg@chromium.org Committed: https://crrev.com/7332d1061793d67ed8f9d3db295f012641bc3233 Cr-Commit-Position: refs/heads/master@{#33920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/factory.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7332d1061793d67ed8f9d3db295f012641bc3233 Cr-Commit-Position: refs/heads/master@{#33920}
4 years, 10 months ago (2016-02-11 19:55:35 UTC) #5
adamk
Committed patchset #1 (id:1) manually as 7332d1061793d67ed8f9d3db295f012641bc3233 (tree was closed).
4 years, 10 months ago (2016-02-11 19:55:36 UTC) #6
rossberg
4 years, 10 months ago (2016-02-12 08:33:38 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698