Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: cc/resources/video_resource_updater.h

Issue 1688033005: Monitor VideoResourceUpdater reusing destructed resource in Debug mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/resources/video_resource_updater.cc » ('j') | cc/resources/video_resource_updater.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/video_resource_updater.h
diff --git a/cc/resources/video_resource_updater.h b/cc/resources/video_resource_updater.h
index 4e11110a01ca1eb89894fe5c775493d0972781f1..bc47b4dae482780db8727ab92fd71a097e41b81f 100644
--- a/cc/resources/video_resource_updater.h
+++ b/cc/resources/video_resource_updater.h
@@ -111,7 +111,11 @@ class CC_EXPORT VideoResourceUpdater
const media::VideoFrame* video_frame,
size_t plane_index);
- static void SetPlaneResourceUniqueId(const media::VideoFrame* video_frame,
+ // Side effect: Marks in the userdata of the VideoFrame to prevent reusing the
+ // resource in the case that the original VideoFrame is destroyed and a new
+ // VideoFrame is re-created with the same pointer and the timestamps are not
+ // correctly set by the client.
+ static void SetPlaneResourceUniqueId(media::VideoFrame* video_frame,
size_t plane_index,
PlaneResource* plane_resource);
« no previous file with comments | « no previous file | cc/resources/video_resource_updater.cc » ('j') | cc/resources/video_resource_updater.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698