cc/resources/video_resource_updater.h - Issue 1688033005: Monitor VideoResourceUpdater reusing destructed resource in Debug mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.h

Issue 1688033005: Monitor VideoResourceUpdater reusing destructed resource in Debug mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and add new VideoFrameMetada field. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/video_resource_updater.h

diff --git a/cc/resources/video_resource_updater.h b/cc/resources/video_resource_updater.h

index 4e11110a01ca1eb89894fe5c775493d0972781f1..bdb4d1c9d256b9d2a0fa82b77ba2180f169fe328 100644

--- a/cc/resources/video_resource_updater.h

+++ b/cc/resources/video_resource_updater.h

@@ -111,7 +111,7 @@ class CC_EXPORT VideoResourceUpdater

const media::VideoFrame* video_frame,

size_t plane_index);

- static void SetPlaneResourceUniqueId(const media::VideoFrame* video_frame,

+ static void SetPlaneResourceUniqueId(media::VideoFrame* video_frame,

miu 2016/02/22 21:17:37 Please add a comment like: // Side effect: Sets

xjz 2016/02/23 03:36:03 Done.

size_t plane_index,

PlaneResource* plane_resource);

« no previous file with comments | « no previous file | cc/resources/video_resource_updater.cc » ('j') | cc/resources/video_resource_updater.cc » ('J')