Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: media/base/video_frame_metadata.h

Issue 1688033005: Monitor VideoResourceUpdater reusing destructed resource in Debug mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_VIDEO_FRAME_METADATA_H_ 5 #ifndef MEDIA_BASE_VIDEO_FRAME_METADATA_H_
6 #define MEDIA_BASE_VIDEO_FRAME_METADATA_H_ 6 #define MEDIA_BASE_VIDEO_FRAME_METADATA_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 // This field represents the local time at which either: 1) the frame was 70 // This field represents the local time at which either: 1) the frame was
71 // generated, if it was done so locally; or 2) the targeted play-out time 71 // generated, if it was done so locally; or 2) the targeted play-out time
72 // of the frame, if it was generated from a remote source. This value is NOT 72 // of the frame, if it was generated from a remote source. This value is NOT
73 // a high-resolution timestamp, and so it should not be used as a 73 // a high-resolution timestamp, and so it should not be used as a
74 // presentation time; but, instead, it should be used for buffering playback 74 // presentation time; but, instead, it should be used for buffering playback
75 // and for A/V synchronization purposes. 75 // and for A/V synchronization purposes.
76 // Use Get/SetTimeTicks() for this key. 76 // Use Get/SetTimeTicks() for this key.
77 REFERENCE_TIME, 77 REFERENCE_TIME,
78 78
79 // Boolean used by cc::VideoResourceUpdater to flag that this video frame's
80 // content has been cached.
81 RESOURCE_UPDATER_FLAG,
xhwang 2016/02/23 17:58:02 Also, media/base knows nothing about "cc" and "Res
xjz 2016/02/23 23:53:15 Removed this flag here. Instead, use base::Support
82
79 // A feedback signal that indicates the fraction of the tolerable maximum 83 // A feedback signal that indicates the fraction of the tolerable maximum
80 // amount of resources that were utilized to process this frame. A producer 84 // amount of resources that were utilized to process this frame. A producer
81 // can check this value after-the-fact, usually via a VideoFrame destruction 85 // can check this value after-the-fact, usually via a VideoFrame destruction
82 // observer, to determine whether the consumer can handle more or less data 86 // observer, to determine whether the consumer can handle more or less data
83 // volume, and achieve the right quality versus performance trade-off. 87 // volume, and achieve the right quality versus performance trade-off.
84 // 88 //
85 // Use Get/SetDouble() for this key. Values are interpreted as follows: 89 // Use Get/SetDouble() for this key. Values are interpreted as follows:
86 // Less than 0.0 is meaningless and should be ignored. 1.0 indicates a 90 // Less than 0.0 is meaningless and should be ignored. 1.0 indicates a
87 // maximum sustainable utilization. Greater than 1.0 indicates the consumer 91 // maximum sustainable utilization. Greater than 1.0 indicates the consumer
88 // is likely to stall or drop frames if the data volume is not reduced. 92 // is likely to stall or drop frames if the data volume is not reduced.
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 const base::BinaryValue* GetBinaryValue(Key key) const; 139 const base::BinaryValue* GetBinaryValue(Key key) const;
136 140
137 base::DictionaryValue dictionary_; 141 base::DictionaryValue dictionary_;
138 142
139 DISALLOW_COPY_AND_ASSIGN(VideoFrameMetadata); 143 DISALLOW_COPY_AND_ASSIGN(VideoFrameMetadata);
140 }; 144 };
141 145
142 } // namespace media 146 } // namespace media
143 147
144 #endif // MEDIA_BASE_VIDEO_FRAME_METADATA_H_ 148 #endif // MEDIA_BASE_VIDEO_FRAME_METADATA_H_
OLDNEW
« cc/resources/video_resource_updater.h ('K') | « cc/resources/video_resource_updater.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698