Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: src/deoptimizer.cc

Issue 1688023003: Remove the JS_FRAME_FUNCTION deoptimizer translation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/deoptimizer.h ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index 9f9ac663cb55bfe5cd674404cef5c9f446282d30..f9bc02428f1f4ffb403a8d1f37215349b10d2a22 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -2360,14 +2360,13 @@ void Translation::StoreArgumentsObject(bool args_known,
void Translation::StoreJSFrameFunction() {
- buffer_->Add(JS_FRAME_FUNCTION, zone());
+ StoreStackSlot((StandardFrameConstants::kCallerPCOffset -
+ StandardFrameConstants::kMarkerOffset) /
+ kPointerSize);
}
-
int Translation::NumberOfOperandsFor(Opcode opcode) {
switch (opcode) {
- case JS_FRAME_FUNCTION:
- return 0;
case GETTER_STUB_FRAME:
case SETTER_STUB_FRAME:
case DUPLICATED_OBJECT:
@@ -3060,7 +3059,6 @@ TranslatedFrame TranslatedState::CreateNextTranslatedFrame(
case Translation::BOOL_STACK_SLOT:
case Translation::DOUBLE_STACK_SLOT:
case Translation::LITERAL:
- case Translation::JS_FRAME_FUNCTION:
break;
}
FATAL("We should never get here - unexpected deopt info.");
@@ -3263,16 +3261,6 @@ TranslatedValue TranslatedState::CreateNextTranslatedValue(
return TranslatedValue::NewTagged(this, value);
}
-
- case Translation::JS_FRAME_FUNCTION: {
- int slot_offset = JavaScriptFrameConstants::kFunctionOffset;
- intptr_t value = *(reinterpret_cast<intptr_t*>(fp + slot_offset));
- if (trace_file != nullptr) {
- PrintF(trace_file, "0x%08" V8PRIxPTR " ; (frame function) ", value);
- reinterpret_cast<Object*>(value)->ShortPrint(trace_file);
- }
- return TranslatedValue::NewTagged(this, reinterpret_cast<Object*>(value));
- }
}
FATAL("We should never get here - unexpected deopt info.");
« no previous file with comments | « src/deoptimizer.h ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698