Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 16880002: [MIPS] Switch the script to use packages from Debian Wheezy (Closed)

Created:
7 years, 6 months ago by petarj
Modified:
7 years, 5 months ago
CC:
native-client-reviews_googlegroups.com, ilevy-cc_chromium.org
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Switch the script to use packages from Debian Wheezy Recent dependencies in Chromium (such as the need to use the latest libnss3 package) prevent us to use Debian Squeeze repository anymore. This change switches it to Debian Wheezy repository and adds minor changes in the script that ensure the toolchain build does not re-download tarballs and SVN checkouts if they are already present. The change also fixes issue #3401 when strcasecmp is statically linked into the QEMU binary. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3401 BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= trusted-toolchain-creator.mipsel.debian.sh nacl_sdk (or chrome_sdk) Committed on behalf of Petar Jovanovic (petarj@mips.com) because the commit queue is currently not working for this change. (The presubmit checks are timing out because they are invoking SVN, which is prompting for credentials.) Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11674

Patch Set 1 #

Total comments: 10

Patch Set 2 : Code review comments. #

Patch Set 3 : Add a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -870 lines) Patch
D tools/trusted_cross_toolchains/packagelist.squeeze.mipsel.base View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/trusted_cross_toolchains/packagelist.squeeze.mipsel.extra View 1 chunk +0 lines, -136 lines 0 comments Download
A + tools/trusted_cross_toolchains/packagelist.wheezy.mipsel.base View 1 chunk +1 line, -1 line 0 comments Download
A + tools/trusted_cross_toolchains/packagelist.wheezy.mipsel.extra View 3 chunks +11 lines, -2 lines 0 comments Download
A + tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.debian.sh View 1 2 16 chunks +131 lines, -64 lines 0 comments Download
D tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh View 1 chunk +0 lines, -663 lines 0 comments Download

Messages

Total messages: 39 (0 generated)
petarj
PTAL.
7 years, 6 months ago (2013-06-12 23:12:09 UTC) #1
petarj
On 2013/06/12 23:12:09, petarj wrote: > PTAL. Ping.
7 years, 6 months ago (2013-06-14 20:46:28 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/16880002/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh (left): https://codereview.chromium.org/16880002/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh#oldcode619 tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh:619: --static Please add "BUG=https://code.google.com/p/nativeclient/issues/detail?id=3401" to the commit message ...
7 years, 6 months ago (2013-06-18 15:26:21 UTC) #3
petarj
PTAL. https://codereview.chromium.org/16880002/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh (left): https://codereview.chromium.org/16880002/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh#oldcode619 tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh:619: --static On 2013/06/18 15:26:21, Mark Seaborn wrote: > ...
7 years, 6 months ago (2013-06-19 23:12:33 UTC) #4
Mark Seaborn
LGTM still https://codereview.chromium.org/16880002/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh (right): https://codereview.chromium.org/16880002/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh#newcode578 tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.wheezy.sh:578: Banner "Fixing includes" On 2013/06/19 23:12:33, petarj ...
7 years, 6 months ago (2013-06-20 01:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-24 00:47:09 UTC) #6
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-24 00:53:11 UTC) #7
petarj
On 2013/06/24 00:53:11, I haz the power (commit-bot) wrote: > Presubmit check for 16880002-12001 failed ...
7 years, 6 months ago (2013-06-24 01:04:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-24 08:41:13 UTC) #9
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-24 08:47:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-24 09:15:47 UTC) #11
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-24 09:21:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-24 13:46:11 UTC) #13
bradn
Checked... -BradN Sent from my phone. On Jun 24, 2013 6:46 AM, <commit-bot@chromium.org> wrote: > ...
7 years, 6 months ago (2013-06-24 13:46:49 UTC) #14
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-24 13:52:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-24 15:46:26 UTC) #16
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-24 15:52:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-24 23:28:50 UTC) #18
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-24 23:34:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-25 17:45:30 UTC) #20
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-25 17:51:33 UTC) #21
iannucci
As I commented on the other thread, the presubmit check is running a remote svn ...
7 years, 6 months ago (2013-06-25 17:59:01 UTC) #22
Mark Seaborn
On 25 June 2013 10:58, Robert Iannucci <iannucci@chromium.org> wrote: > As I commented on the ...
7 years, 6 months ago (2013-06-25 18:03:42 UTC) #23
iannucci
I'm not sure, but I see presubmit_support.py with a svn info child process. I'll look ...
7 years, 6 months ago (2013-06-25 18:10:32 UTC) #24
iannucci
Hm... It looks like it may try to do a remote info call if it ...
7 years, 6 months ago (2013-06-25 18:20:18 UTC) #25
iannucci
**needs to generate a diff and there are renamed/moved files On Tue, Jun 25, 2013 ...
7 years, 6 months ago (2013-06-25 18:20:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 6 months ago (2013-06-27 00:15:12 UTC) #27
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 6 months ago (2013-06-27 00:21:16 UTC) #28
petarj
On 2013/06/27 00:21:16, I haz the power (commit-bot) wrote: > Presubmit check for 16880002-12001 failed ...
7 years, 6 months ago (2013-06-27 00:26:11 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 5 months ago (2013-06-27 17:53:35 UTC) #30
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 5 months ago (2013-06-27 17:59:37 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/16880002/12001
7 years, 5 months ago (2013-06-27 18:08:00 UTC) #32
commit-bot: I haz the power
Presubmit check for 16880002-12001 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 5 months ago (2013-06-27 18:14:02 UTC) #33
iannucci
On 2013/06/27 18:14:02, I haz the power (commit-bot) wrote: > Presubmit check for 16880002-12001 failed ...
7 years, 5 months ago (2013-06-27 19:12:05 UTC) #34
petarj
On 2013/06/27 19:12:05, iannucci wrote: > On 2013/06/27 18:14:02, I haz the power (commit-bot) wrote: ...
7 years, 5 months ago (2013-06-28 00:44:29 UTC) #35
Mark Seaborn
On 27 June 2013 17:44, <petarj@mips.com> wrote: > On 2013/06/27 19:12:05, iannucci wrote: > >> ...
7 years, 5 months ago (2013-06-28 01:36:18 UTC) #36
petarj
On 2013/06/28 01:36:18, Mark Seaborn wrote: > On 27 June 2013 17:44, <mailto:petarj@mips.com> wrote: > ...
7 years, 5 months ago (2013-07-01 18:10:44 UTC) #37
Mark Seaborn
Committed patchset #3 manually as r11674 (presubmit successful).
7 years, 5 months ago (2013-07-03 19:18:08 UTC) #38
Mark Seaborn
7 years, 5 months ago (2013-07-03 20:04:54 UTC) #39
On 3 July 2013 12:18, <mseaborn@chromium.org> wrote:

> Committed patchset #3 manually as r11674 (presubmit successful).
>

I've committed the change on your behalf.  Sorry that committing this
change has been so painfully slow.

I'm not sure if the commit queue is working for NaCl at all at the moment,
or if the problem only occurred because the change contained file renames.
If you have more problems with the commit queue, can you file an issue via
https://code.google.com/p/chromium/issues/entry?template=Build%20Infrastructu...
CC me, please?

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.


Powered by Google App Engine
This is Rietveld 408576698