Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1687933004: Revert of Make instrumentation_test_apk depend on their apk_under_test. (Closed)

Created:
4 years, 10 months ago by hartmanng
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dist-jar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make instrumentation_test_apk depend on their apk_under_test. (patchset #2 id:70001 of https://codereview.chromium.org/1687723002/ ) Reason for revert: Speculative revert to try to fix widespread Android build failures: http://crbug.com/586120 Original issue's description: > Tweak GN deps of instrumentation apks > > Reland of https://codereview.chromium.org/1683823002/ > > This improves build concurrency a little bit. > > BUG=none TBR=jbudorick@chromium.org,iclelland@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/0a5c74a4518334715b56dd54c7749a1b2c856ea6 Cr-Commit-Position: refs/heads/master@{#374895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hartmanng
Created Revert of Make instrumentation_test_apk depend on their apk_under_test.
4 years, 10 months ago (2016-02-11 15:15:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687933004/1
4 years, 10 months ago (2016-02-11 15:16:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 15:18:15 UTC) #3
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1690983002/ by agrieve@chromium.org. ...
4 years, 10 months ago (2016-02-11 17:03:19 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:35:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a5c74a4518334715b56dd54c7749a1b2c856ea6
Cr-Commit-Position: refs/heads/master@{#374895}

Powered by Google App Engine
This is Rietveld 408576698