Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1687933002: Move RasterDeviceTooBigToAllocate to caller (Closed)

Created:
4 years, 10 months ago by tomhudson
Modified:
4 years, 10 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RasterDeviceTooBigToAllocate to caller RasterDeviceTooBigToAllocate() is a utility function only used from a single cc file; move it out of the header into that file. R=fmalita@chromium.org Committed: https://crrev.com/3a6a4e5e8f1b4fd564e8b50931dc82ed75d180cc Cr-Commit-Position: refs/heads/master@{#374705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M skia/ext/bitmap_platform_device.h View 1 chunk +0 lines, -15 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tomhudson
Another tiny cleanup.
4 years, 10 months ago (2016-02-10 18:59:24 UTC) #1
f(malita)
lgtm
4 years, 10 months ago (2016-02-10 19:07:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687933002/1
4 years, 10 months ago (2016-02-10 19:11:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 19:52:14 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a6a4e5e8f1b4fd564e8b50931dc82ed75d180cc
Cr-Commit-Position: refs/heads/master@{#374705}

Powered by Google App Engine
This is Rietveld 408576698