Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 168793002: Attempt at making ToplevelWindowEventHandlerTest.RunMoveLoopFailsDuringInProgressDrag less flaky (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Attempt at making ToplevelWindowEventHandlerTest.RunMoveLoopFailsDuringInProgressDrag less flaky The test seems to pass fine when I run it manually on Windows Ash (including with high values of --gtest_repeat) This CL: - Makes ToplevelWindowEventHandlerTest.RunMoveLoopFailsDuringInProgressDrag look more like ToplevelWindowEventHandlerTest.Caption which I don't think is flaky on Windows Ash. - Adds an extra check which will help better understand the source of the flakiness should it occur again BUG=343167 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ash/wm/toplevel_window_event_handler_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
James, can you please take a look? I suspect that all of ToplevelWindowEventHandlerTest are flaky ...
6 years, 10 months ago (2014-02-16 02:18:15 UTC) #1
James Cook
LGTM
6 years, 10 months ago (2014-02-18 19:13:59 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 19:55:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168793002/1
6 years, 10 months ago (2014-02-18 19:56:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:05:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265777
6 years, 10 months ago (2014-02-18 21:05:12 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 22:15:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168793002/1
6 years, 10 months ago (2014-02-18 22:16:51 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 00:33:07 UTC) #9
Message was sent while issue was closed.
Change committed as 251899

Powered by Google App Engine
This is Rietveld 408576698