Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1687923002: Finally get rid of depot_tools' breakpad. (Closed)

Created:
4 years, 10 months ago by tandrii(chromium)
Modified:
4 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Finally get rid of depot_tools' breakpad. Reland of http://crrev.com/1689633002#ps20001 without breaking other repos by means of keeping breakpad.py importable, but otherwise a no-op. R=maruel@chromium.org BUG=585837 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298731

Patch Set 1 #

Patch Set 2 : add no-op breakpad.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -298 lines) Patch
M apply_issue.py View 1 chunk +0 lines, -1 line 0 comments Download
D breakpad.py View 1 1 chunk +6 lines, -141 lines 0 comments Download
M commit_queue.py View 1 chunk +0 lines, -2 lines 0 comments Download
M drover.py View 3 chunks +2 lines, -3 lines 0 comments Download
M gcl.py View 2 chunks +0 lines, -8 lines 0 comments Download
M gclient.py View 1 chunk +0 lines, -2 lines 0 comments Download
M git_cl.py View 2 chunks +0 lines, -7 lines 0 comments Download
M git_try.py View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/breakpad_unittest.py View 1 chunk +0 lines, -123 lines 0 comments Download
M tests/git_cl_test.py View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/trychange_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M trychange.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tandrii(chromium)
PTAL
4 years, 10 months ago (2016-02-10 18:31:31 UTC) #1
M-A Ruel
lgtm
4 years, 10 months ago (2016-02-10 18:54:32 UTC) #2
Dirk Pranke
strange, I wonder why rietveld shows this file as "D" when it's not supposed to ...
4 years, 10 months ago (2016-02-10 19:01:55 UTC) #3
tandrii(chromium)
On 2016/02/10 19:01:55, Dirk Pranke wrote: > strange, I wonder why rietveld shows this file ...
4 years, 10 months ago (2016-02-11 08:21:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687923002/20001
4 years, 10 months ago (2016-02-11 08:21:48 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 08:23:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298731

Powered by Google App Engine
This is Rietveld 408576698