Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1687873002: Revert of Refactor Chromoting JNI code to use jni/Client (Java changes only). (Closed)

Created:
4 years, 10 months ago by hartmanng
Modified:
4 years, 10 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor Chromoting JNI code to use jni/Client (Java changes only). (patchset #7 id:120001 of https://codereview.chromium.org/1537183002/ ) Reason for revert: This broke ToT: http://crbug.com/585799 Original issue's description: > Refactor Chromoting JNI code to use jni/Client (Java changes only). > > This removes globals from jni/JniInterface in favor of passing a > jni/Client instance to code that needs to access the Chromoting > client connection. > > The C++ code is unchanged - JniInterface class is still used to > marshall Java <-> C++ calls. JniInterface still holds a singleton > Client connection, but all other globals have been removed (including > the singleton CapabilityManager instance). > > Each Activity's onCreate() method gets the singleton Client instance, > and then passes it to objects that need it (for input injection and > so on). This should make it easier to use a fake Client instance for > unit-instrumentation tests. > > BUG=526336 > > Committed: https://crrev.com/22ee9b8426839b0c2c841fbc919cd4a79b1456d0 > Cr-Commit-Position: refs/heads/master@{#374548} TBR=sergeyu@chromium.org,joedow@chromium.org,lambroslambrou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526336 Committed: https://crrev.com/6fd49ae9090db2678c07f0479a96e7dbd6651dff Cr-Commit-Position: refs/heads/master@{#374660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -573 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/CapabilityManager.java View 4 chunks +23 lines, -1 line 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 5 chunks +4 lines, -23 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 14 chunks +24 lines, -29 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/DesktopView.java View 9 chunks +10 lines, -18 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SessionAuthenticator.java View 5 chunks +6 lines, -10 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SessionConnector.java View 3 chunks +5 lines, -6 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java View 6 chunks +5 lines, -7 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java View 3 chunks +5 lines, -8 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java View 5 chunks +5 lines, -7 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/cardboard/CardboardRenderer.java View 7 chunks +7 lines, -9 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/cardboard/Cursor.java View 6 chunks +5 lines, -8 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/cardboard/Desktop.java View 5 chunks +4 lines, -7 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java View 8 chunks +9 lines, -13 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/Client.java View 2 chunks +2 lines, -371 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 10 chunks +273 lines, -52 lines 0 comments Download
M remoting/android/javatests/src/org/chromium/chromoting/TouchInputStrategyTest.java View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hartmanng
Created Revert of Refactor Chromoting JNI code to use jni/Client (Java changes only).
4 years, 10 months ago (2016-02-10 14:59:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687873002/1
4 years, 10 months ago (2016-02-10 14:59:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 15:01:39 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 15:03:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fd49ae9090db2678c07f0479a96e7dbd6651dff
Cr-Commit-Position: refs/heads/master@{#374660}

Powered by Google App Engine
This is Rietveld 408576698