Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1687813003: Enable asm-wasm mjsunit tests. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable asm-wasm mjsunit tests. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/46728d4d9576585bceaa66b8362755c29d3e54bd Cr-Commit-Position: refs/heads/master@{#33883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
aseemgarg
lgtm
4 years, 10 months ago (2016-02-11 02:19:31 UTC) #1
bradnelson
Ok, sees to work locally with sse4.1 off. Here goes...
4 years, 10 months ago (2016-02-11 06:33:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687813003/1
4 years, 10 months ago (2016-02-11 06:34:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10783)
4 years, 10 months ago (2016-02-11 06:36:02 UTC) #6
bradn
titzer, can haz OWNERS review? Thanks
4 years, 10 months ago (2016-02-11 06:38:59 UTC) #8
Michael Achenbach
lgtm
4 years, 10 months ago (2016-02-11 08:23:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687813003/1
4 years, 10 months ago (2016-02-11 08:23:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 08:25:52 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/46728d4d9576585bceaa66b8362755c29d3e54bd Cr-Commit-Position: refs/heads/master@{#33883}
4 years, 10 months ago (2016-02-11 10:41:13 UTC) #15
Michael Achenbach
4 years, 10 months ago (2016-02-11 15:28:16 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1689113003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks chromebooks with arm:
https://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/4397

You can reland, but please keep it skipped for arm..

Powered by Google App Engine
This is Rietveld 408576698