Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1687793002: Use effectivePreloadType() where possible (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
Srirama, fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use effectivePreloadType() where possible preloadType() is still used in two places where it ideally should not, HTMLMediaElement::setPlayerPreload and HTMLMediaElement::seek, but changing those would probably be observable and need tests. Drive-by: Drop two unused HTMLMediaElement state bits R=fs@opera.com Committed: https://crrev.com/d48519f92275c1946aaf3c66ca6f144d6d2bd3c2 Cr-Commit-Position: refs/heads/master@{#374897}

Patch Set 1 #

Patch Set 2 : rm m_completelyLoaded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 4 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
philipj_slow
4 years, 10 months ago (2016-02-10 04:58:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687793002/1
4 years, 10 months ago (2016-02-10 04:59:23 UTC) #3
fs
lgtm
4 years, 10 months ago (2016-02-10 08:50:07 UTC) #5
Srirama
Do we need "BUG=" in description?
4 years, 10 months ago (2016-02-10 11:57:02 UTC) #7
fs
On 2016/02/10 at 11:57:02, srirama.m wrote: > Do we need "BUG=" in description? No, but ...
4 years, 10 months ago (2016-02-10 11:57:59 UTC) #9
fs
On 2016/02/10 at 11:57:59, fs wrote: > On 2016/02/10 at 11:57:02, srirama.m wrote: > > ...
4 years, 10 months ago (2016-02-10 11:58:08 UTC) #10
philipj_slow
On 2016/02/10 11:58:08, fs wrote: > On 2016/02/10 at 11:57:59, fs wrote: > > On ...
4 years, 10 months ago (2016-02-11 14:32:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687793002/20001
4 years, 10 months ago (2016-02-11 14:33:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 15:39:00 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:35:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d48519f92275c1946aaf3c66ca6f144d6d2bd3c2
Cr-Commit-Position: refs/heads/master@{#374897}

Powered by Google App Engine
This is Rietveld 408576698