Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1687723002: Reland of Make instrumentation_test_apk depend on their apk_under_test. (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick, iclelland
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dist-jar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak GN deps of instrumentation apks Reland of https://codereview.chromium.org/1683823002/ This improves build concurrency a little bit. BUG=none Committed: https://crrev.com/805aaf431e3694e870df4689735aa0040f58de1f Cr-Commit-Position: refs/heads/master@{#374816}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/config/android/internal_rules.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
agrieve
Created Reland of Make instrumentation_test_apk depend on their apk_under_test.
4 years, 10 months ago (2016-02-10 01:45:12 UTC) #1
agrieve
On 2016/02/10 01:45:12, agrieve wrote: > Created Reland of Make instrumentation_test_apk depend on their apk_under_test. ...
4 years, 10 months ago (2016-02-10 01:49:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687723002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687723002/70001
4 years, 10 months ago (2016-02-10 17:06:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 17:51:40 UTC) #7
jbudorick
lgtm
4 years, 10 months ago (2016-02-10 21:34:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687723002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687723002/70001
4 years, 10 months ago (2016-02-11 00:56:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 10 months ago (2016-02-11 01:07:05 UTC) #12
hartmanng
A revert of this CL (patchset #2 id:70001) has been created in https://codereview.chromium.org/1687933004/ by hartmanng@chromium.org. ...
4 years, 10 months ago (2016-02-11 15:15:51 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/805aaf431e3694e870df4689735aa0040f58de1f
Cr-Commit-Position: refs/heads/master@{#374816}

Powered by Google App Engine
This is Rietveld 408576698