Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1687693003: Update AccelerometerReader Error Output (Closed)

Created:
4 years, 10 months ago by jonross
Modified:
4 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update AccelerometerReader Error Output Change log level from ERROR to WARNING so as to reduce confusion in testing bot logs. TEST=manual testing on device BUG=585508 Committed: https://crrev.com/6745b1f7c1e4afe9feffdf835ba6280033172d5a Cr-Commit-Position: refs/heads/master@{#374698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromeos/accelerometer/accelerometer_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
jonross
Hi Steven, Could you provide the owner review for this change? I'm updating a log ...
4 years, 10 months ago (2016-02-10 18:28:21 UTC) #2
stevenjb
Thanks! LGTM
4 years, 10 months ago (2016-02-10 18:36:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687693003/1
4 years, 10 months ago (2016-02-10 18:39:29 UTC) #5
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-10 19:21:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 19:25:05 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6745b1f7c1e4afe9feffdf835ba6280033172d5a
Cr-Commit-Position: refs/heads/master@{#374698}

Powered by Google App Engine
This is Rietveld 408576698