Issue 1687653003: Slightly improve recovery from losing GL context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1687653003: Slightly improve recovery from losing GL context. (Closed)

Created:
4 years, 10 months ago by jeffbrown

Modified:
4 years, 10 months ago

Reviewers:
abarth

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Slightly improve recovery from losing GL context. This is still somewhat broken but at least it doesn't crash due to reentrance. We should probably rethink how GLContext lifetime is managed in general. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/894f596a19e69bd1991b99b1e764c1b2ca17bea9

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	mojo/skia/ganesh_context.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	mojo/skia/ganesh_context.cc	View		2 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jeffbrown

4 years, 10 months ago (2016-02-10 19:07:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
894f596a19e69bd1991b99b1e764c1b2ca17bea9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages