Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 16876006: ios: keep scoped_nsobject in source lists. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, stuartmorgan
Visibility:
Public.

Description

ios: keep scoped_nsobject in source lists. Noticed by Stuart. BUG=251957 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 6 months ago (2013-06-21 17:43:28 UTC) #1
Mark Mentovai
LGTM
7 years, 6 months ago (2013-06-21 17:54:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/16876006/1
7 years, 6 months ago (2013-06-21 17:57:22 UTC) #3
Nico
7 years, 6 months ago (2013-06-21 18:15:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r207881 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698