Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1687583002: Add DirectoryBasedDartSdk.useSummary property. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/sdk_io.dart View 3 chunks +22 lines, -4 lines 2 comments Download
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-09 20:34:53 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1687583002/diff/1/pkg/analyzer/lib/src/generated/sdk_io.dart File pkg/analyzer/lib/src/generated/sdk_io.dart (right): https://codereview.chromium.org/1687583002/diff/1/pkg/analyzer/lib/src/generated/sdk_io.dart#newcode401 pkg/analyzer/lib/src/generated/sdk_io.dart:401: * before [context] was invoked. s/was/is/
4 years, 10 months ago (2016-02-09 20:36:09 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/1687583002/diff/1/pkg/analyzer/lib/src/generated/sdk_io.dart File pkg/analyzer/lib/src/generated/sdk_io.dart (right): https://codereview.chromium.org/1687583002/diff/1/pkg/analyzer/lib/src/generated/sdk_io.dart#newcode212 pkg/analyzer/lib/src/generated/sdk_io.dart:212: bool _useSummary = false; I don't understand what the ...
4 years, 10 months ago (2016-02-09 20:41:07 UTC) #3
scheglov
4 years, 10 months ago (2016-02-09 20:49:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
abc69cb2322e65d90883cd7f765e68af244d6dc8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698