Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1687543004: Remove AsyncResult::RESULT_FAILED_DIRECTORY (Closed)

Created:
4 years, 10 months ago by Jamie
Modified:
4 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AsyncResult::RESULT_FAILED_DIRECTORY. It's not used anywhere other than some code to communicate it to the webapp (where it's also not used). Committed: https://crrev.com/436f2d7081442a64c01e5e52c25a86a34707119e Cr-Commit-Position: refs/heads/master@{#374837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M remoting/host/setup/daemon_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/host_controller.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jamie
ptal
4 years, 10 months ago (2016-02-10 01:52:42 UTC) #4
Sergey Ulanov
lgtm
4 years, 10 months ago (2016-02-10 23:42:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687543004/1
4 years, 10 months ago (2016-02-11 01:38:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 02:24:22 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/436f2d7081442a64c01e5e52c25a86a34707119e
Cr-Commit-Position: refs/heads/master@{#374837}

Powered by Google App Engine
This is Rietveld 408576698