Fix crash from r374241 when renderers are using more than 2GB of cache memory.

Fix crash from r374241 when renderers are using more than 2GB of cache memory.

For now do a simple fix for the serializers. This will maintain current behavior. A bigger fix will come later that'll make a 32 bit browser handle large memory usage of 64 bit renderers correctly.

BUG=585382
Committed: https://crrev.com/84246f0e86b750cee0ccc1942b49147554c354b0
Cr-Commit-Position: refs/heads/master@{#374560}

[jam, 2016-02-09 22:55:56]

jam@chromium.org changed reviewers:
+ tsepez@chromium.org

[jam, 2016-02-09 23:00:17]

https://codereview.chromium.org/1687543003/diff/1/chrome/common/render_messag...
File chrome/common/render_messages.cc (right):

https://codereview.chromium.org/1687543003/diff/1/chrome/common/render_messag...
chrome/common/render_messages.cc:57: u->deadSize =
base::checked_cast<size_t>(dead_size);
this should be safe since right now don't have 32 bit browser talking to 64 bit
renderer

[Wez, 2016-02-09 23:03:02]

IIUC the approach is to always use 64-bit in the IPCs, regardless of arch, and
then by checked-cast to size_t we effectively only check on 32-bit systems,
which inherently can't have any of these values exceeding 2GB anyway?

LGTM :)

[nasko, 2016-02-10 00:12:33]

nasko@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2016-02-10 00:12:33]

LGTM

[jam, 2016-02-10 00:13:26]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-02-10 00:14:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687543003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687543003/1

[Tom Sepez, 2016-02-10 00:27:29]

lgtm

https://codereview.chromium.org/1687543003/diff/1/chrome/common/render_messag...
File chrome/common/render_messages.cc (right):

https://codereview.chromium.org/1687543003/diff/1/chrome/common/render_messag...
chrome/common/render_messages.cc:44: uint64_t min_capacity, max_capacity,
capacity, live_size, dead_size;
nit: one per line.

[commit-bot: I haz the power, 2016-02-10 01:08:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-10 01:11:23]

Description was changed from

==========
Fix crash from r374241 when renderers are using more than 2GB of cache memory.

For now do a simple fix for the serializers. This will maintain current
behavior. A bigger fix will come later that'll make a 32 bit browser handle
large memory usage of 64 bit renderers correctly.

BUG=585382
==========

to

==========
Fix crash from r374241 when renderers are using more than 2GB of cache memory.

For now do a simple fix for the serializers. This will maintain current
behavior. A bigger fix will come later that'll make a 32 bit browser handle
large memory usage of 64 bit renderers correctly.

BUG=585382

Committed: https://crrev.com/84246f0e86b750cee0ccc1942b49147554c354b0
Cr-Commit-Position: refs/heads/master@{#374560}
==========

[commit-bot: I haz the power, 2016-02-10 01:11:24]

Patchset 1 (id:??) landed as
https://crrev.com/84246f0e86b750cee0ccc1942b49147554c354b0
Cr-Commit-Position: refs/heads/master@{#374560}