Fix IceTransportTest.TestBrokenTransport

Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

Fixed both issues.

BUG=585531
Committed: https://crrev.com/785b2e72967a5ddb877091776c53ae3eca197775
Cr-Commit-Position: refs/heads/master@{#374536}

[Sergey Ulanov, 2016-02-09 19:46:14]

Description was changed from

==========
Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

BUG=585531
==========

to

==========
Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

Fixed both issues.

BUG=585531
==========

[Sergey Ulanov, 2016-02-09 19:46:14]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-02-09 22:21:12]

lgtm

[Sergey Ulanov, 2016-02-09 23:02:41]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:05:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687543002/20001

[commit-bot: I haz the power, 2016-02-09 23:49:18]

Description was changed from

==========
Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

Fixed both issues.

BUG=585531
==========

to

==========
Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

Fixed both issues.

BUG=585531
==========

[commit-bot: I haz the power, 2016-02-09 23:49:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-09 23:50:17]

Description was changed from

==========
Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

Fixed both issues.

BUG=585531
==========

to

==========
Fix IceTransportTest.TestBrokenTransport

Previously the test wasn't verifying what it's supposed to verify and
was flaky, particularly on DrMemory bots. The test attemps to connect
two IceTransport instances with settings that should prevent them from
connecting and verifies that they fail to connect. There were two issues:
 1. NetworkSettings were not passed to IceTransport objects properly,
    so they could still connect.
 2. The test was just calling RunLoopUntilIdle() and wasn't waiting
    for transport failure, so in most cases the test would pass even if
    the transports could connect, which masked (1).

Fixed both issues.

BUG=585531

Committed: https://crrev.com/785b2e72967a5ddb877091776c53ae3eca197775
Cr-Commit-Position: refs/heads/master@{#374536}
==========

[commit-bot: I haz the power, 2016-02-09 23:50:18]

Patchset 2 (id:??) landed as
https://crrev.com/785b2e72967a5ddb877091776c53ae3eca197775
Cr-Commit-Position: refs/heads/master@{#374536}