Introduce IntrinsicSizingInfo

Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
Committed: https://crrev.com/2bb97b3a880a9ab5bd0be0ed71ab4e3b21d6aede
Cr-Commit-Position: refs/heads/master@{#374635}

[davve, 2016-02-09 17:38:00]

davve@opera.com changed reviewers:
+ fs@opera.com

[davve, 2016-02-09 17:38:01]

To be judged together with dependent CL. I made an attempt at going for
LengthSize instead of FloatSize for intrinsic size but got into all sorts of
strange cases where I needed to add code for scaling, transposing LengthSize.

So having bools for "no intrinsic width/height" for the cases where it really
matters is where I landed. But that's in the next patch, this patch only sets
the scene for carrying those bools around.

[fs, 2016-02-09 18:37:04]

On 2016/02/09 at 17:38:01, davve wrote:
> To be judged together with dependent CL. I made an attempt at going for
LengthSize instead of FloatSize for intrinsic size but got into all sorts of
strange cases where I needed to add code for scaling, transposing LengthSize.
> 
> So having bools for "no intrinsic width/height" for the cases where it really
matters is where I landed. But that's in the next patch, this patch only sets
the scene for carrying those bools around.

Yeah, this looks pretty great! LGTM w/ nits.

Description nit: seperate -> separate

[fs, 2016-02-09 18:37:30]

And here's the other nit...

https://codereview.chromium.org/1687503002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutReplaced.cpp (right):

https://codereview.chromium.org/1687503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutReplaced.cpp:177: FloatSize
LayoutReplaced::constrainIntrinsicSizeToMinMax(IntrinsicSizingInfo&
intrinsicSizingInfo) const
Nit: const IntrinsicSizingInfo&?

[davve, 2016-02-10 08:48:01]

The CQ bit was checked by davve@opera.com

[davve, 2016-02-10 08:48:01]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1687503002/#ps20001
(title: "Make passed reference const")

[commit-bot: I haz the power, 2016-02-10 08:48:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687503002/20001

[davve, 2016-02-10 09:41:46]

The CQ bit was unchecked by davve@opera.com

[davve, 2016-02-10 09:43:54]

Description was changed from

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifially whether
intrinsic size are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a seperate
function constrainIntrinsicSizeToMinMax. In the process remove FIXME
about moving code back to some undefined previous state that would've
been even more confusing now that the code has moved around even more.

BUG=585467
==========

to

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifially whether
intrinsic size are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

[davve, 2016-02-10 09:44:20]

Description was changed from

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifially whether
intrinsic size are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

to

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic size are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

[davve, 2016-02-10 09:44:26]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-02-10 09:44:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687503002/20001

[davve, 2016-02-10 09:52:11]

Description was changed from

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic size are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

to

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

[davve, 2016-02-10 10:10:33]

https://codereview.chromium.org/1687503002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutReplaced.cpp (right):

https://codereview.chromium.org/1687503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutReplaced.cpp:177: FloatSize
LayoutReplaced::constrainIntrinsicSizeToMinMax(IntrinsicSizingInfo&
intrinsicSizingInfo) const
On 2016/02/09 18:37:30, fs wrote:
> Nit: const IntrinsicSizingInfo&?

Done.

[commit-bot: I haz the power, 2016-02-10 10:36:37]

Description was changed from

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

to

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

[commit-bot: I haz the power, 2016-02-10 10:36:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-10 10:37:35]

Description was changed from

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467
==========

to

==========
Introduce IntrinsicSizingInfo

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467

Committed: https://crrev.com/2bb97b3a880a9ab5bd0be0ed71ab4e3b21d6aede
Cr-Commit-Position: refs/heads/master@{#374635}
==========

[commit-bot: I haz the power, 2016-02-10 10:37:36]

Patchset 2 (id:??) landed as
https://crrev.com/2bb97b3a880a9ab5bd0be0ed71ab4e3b21d6aede
Cr-Commit-Position: refs/heads/master@{#374635}