Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1687493002: Add dart2snapshot compiler and dart_snapshotted runtime to test scripts (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart2snapshot compiler and dart_snapshotted runtime to test scripts Command to run tests: $ ./tools/test.py -c dart2snapshot -r dart_snapshotted Each tests will be run twice. After the first run a snapshot will be written to disk and then the test will be run again from the snapshot. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/516e814cd8594537fef0dacff62e53570801a7cc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -4 lines) Patch
M tests/lib/lib.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 2 chunks +90 lines, -0 lines 1 comment Download
M tools/testing/dart/runtime_configuration.dart View 3 chunks +25 lines, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 10 months ago (2016-02-09 16:49:19 UTC) #3
siva
lgtm https://codereview.chromium.org/1687493002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/1687493002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode76 tools/testing/dart/compiler_configuration.dart:76: case 'dart2snapshot': As discussed offline maybe dartproduction or ...
4 years, 10 months ago (2016-02-09 18:59:50 UTC) #4
Cutch
On 2016/02/09 18:59:50, siva wrote: > lgtm > > https://codereview.chromium.org/1687493002/diff/1/tools/testing/dart/compiler_configuration.dart > File tools/testing/dart/compiler_configuration.dart (right): > ...
4 years, 10 months ago (2016-02-09 20:15:15 UTC) #5
Cutch
4 years, 10 months ago (2016-02-09 20:19:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
516e814cd8594537fef0dacff62e53570801a7cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698