Fixed leak on LRU snapshot cache implementation.

Fixed leak on LRU snapshot cache implementation.

Pinned snapshot images were leaked when receiving a memory warning.

BUG=585473
Committed: https://crrev.com/f9b4270d31f06b847ede0f4fe420757a6eac0deb
Cr-Commit-Position: refs/heads/master@{#374669}

[jbbegue (google), 2016-02-09 14:38:00]

jbbegue@google.com changed reviewers:
+ jbbegue@google.com, sdefresne@chromium.org

[jbbegue (google), 2016-02-09 14:38:00]

PTAL

[sdefresne, 2016-02-09 16:17:07]

lgtm with nit

https://codereview.chromium.org/1687453002/diff/1/ios/chrome/browser/snapshot...
File ios/chrome/browser/snapshots/snapshot_cache.mm (right):

https://codereview.chromium.org/1687453002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache.mm:392: NSMutableDictionary*
dictionary =
nit: the recommended pattern in Chromium is to use base::scoped_nsobject<>
instead of autorelease/retain.

[jbbegue (google), 2016-02-10 15:10:23]

https://codereview.chromium.org/1687453002/diff/1/ios/chrome/browser/snapshot...
File ios/chrome/browser/snapshots/snapshot_cache.mm (right):

https://codereview.chromium.org/1687453002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache.mm:392: NSMutableDictionary*
dictionary =
On 2016/02/09 16:17:07, sdefresne wrote:
> nit: the recommended pattern in Chromium is to use base::scoped_nsobject<>
> instead of autorelease/retain.

Done.

[sdefresne, 2016-02-10 15:26:42]

lgtm

[jbbegue (google), 2016-02-10 16:04:39]

The CQ bit was checked by jbbegue@google.com

[commit-bot: I haz the power, 2016-02-10 16:05:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687453002/20001

[commit-bot: I haz the power, 2016-02-10 16:15:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-10 16:16:14]

Description was changed from

==========
Fixed leak on LRU snapshot cache implementation.

Pinned snapshot images were leaked when receiving a memory warning.

BUG=None
==========

to

==========
Fixed leak on LRU snapshot cache implementation.

Pinned snapshot images were leaked when receiving a memory warning.

BUG=None

Committed: https://crrev.com/f9b4270d31f06b847ede0f4fe420757a6eac0deb
Cr-Commit-Position: refs/heads/master@{#374669}
==========

[commit-bot: I haz the power, 2016-02-10 16:16:15]

Patchset 2 (id:??) landed as
https://crrev.com/f9b4270d31f06b847ede0f4fe420757a6eac0deb
Cr-Commit-Position: refs/heads/master@{#374669}

[jbbegue (google), 2016-02-12 13:18:01]

Description was changed from

==========
Fixed leak on LRU snapshot cache implementation.

Pinned snapshot images were leaked when receiving a memory warning.

BUG=None

Committed: https://crrev.com/f9b4270d31f06b847ede0f4fe420757a6eac0deb
Cr-Commit-Position: refs/heads/master@{#374669}
==========

to

==========
Fixed leak on LRU snapshot cache implementation.

Pinned snapshot images were leaked when receiving a memory warning.

BUG=585473

Committed: https://crrev.com/f9b4270d31f06b847ede0f4fe420757a6eac0deb
Cr-Commit-Position: refs/heads/master@{#374669}
==========