Issue 16874005: Merge r205158 (SocketStream uses a weak ptr to URLRequestContext)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16874005: Merge r205158 (SocketStream uses a weak ptr to URLRequestContext) (Closed)

Created:
7 years, 6 months ago by yhirano

Modified:
7 years, 6 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge https://src.chromium.org/viewvc/chrome?revision=205158&view=revision > SocketStream uses a weak ptr to URLRequestContext > > URLRequestContext can be destroyed while SocketStream is living, so we use WeakPtr to detect the destruction. > This is a workaround and this issue should be fixed in a better way in the future. > > Imported from https://codereview.chromium.org/15736021/ . > > TEST=net_unittests content_unittests > BUG=244746 > R=mmenke TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207763

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -11 lines)			Patch
M	chrome/browser/net/chrome_url_request_context.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/socket_stream/socket_stream.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	net/socket_stream/socket_stream_job.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/socket_stream/socket_stream_unittest.cc	View	1 chunk	+62 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_context.h	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

yhirano

7 years, 6 months ago (2013-06-21 09:03:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r207763 (presubmit successful).