blimp/client/app/blimp_client_switches.cc - Issue 1687393002: Add assigner support to Blimp

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/app/blimp_client_switches.cc

Issue 1687393002: Add assigner support to Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added tests and addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « blimp/client/app/blimp_client_switches.h ('k') | blimp/client/app/linux/blimp_client_session_linux.h » ('j') | blimp/client/session/assignment_source_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "blimp/client/app/blimp_client_switches.h"	5 #include "blimp/client/app/blimp_client_switches.h"

6	6

7 namespace blimp {	7 namespace blimp {

8 namespace switches {	8 namespace switches {

9	9

10 // Specifies the blimplet IP-address to connect to, e.g.:	10 // Specifies the blimplet IP-address and port to connect to, e.g.:

11 // --blimplet-host="127.0.0.1".	11 // --blimplet-host="127.0.0.1:25467".
	Kevin M 2016/02/17 22:00:15 Ooh, this conflicts with my SSL CL, which adds eve Ooh, this conflicts with my SSL CL, which adds even more parameters. I like what this is doing, but I think it's incomplete without a scheme, e.g. tcp://, ssl://, quic:// David Trainor- moved to gerrit 2016/02/17 23:02:31 Done. Changed it to tcp:, ssl:, or quic: b/c stan Show quoted text On 2016/02/17 22:00:15, Kevin M wrote: > Ooh, this conflicts with my SSL CL, which adds even more parameters. > > I like what this is doing, but I think it's incomplete without a scheme, e.g. > tcp://, ssl://, quic:// Done. Changed it to tcp:, ssl:, or quic: b/c standard scheme stuff with separators :(.
12 // TODO(nyquist): Add support for DNS-lookup. See http://crbug.com/576857.	12 // TODO(nyquist): Add support for DNS-lookup. See http://crbug.com/576857.

13 const char kBlimpletHost[] = "blimplet-host";	13 const char kBlimpletEndpoint[] = "blimplet-endpoint";

14

15 // Specifies the blimplet port to connect to, e.g.:

16 // --blimplet-tcp-port=25467.

17 const char kBlimpletTCPPort[] = "blimplet-tcp-port";

18	14

19 } // namespace switches	15 } // namespace switches

20 } // namespace blimp	16 } // namespace blimp

OLD	NEW