Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1687323003:
gn/win: Add a runtime_link_output to tool("solink") (Closed)
Descriptiongn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
NOTRY=true
Committed: https://crrev.com/4d1b63a0366d4590efd6c29d62d2308c4a2941c8
Cr-Commit-Position: refs/heads/master@{#374894}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
==========
to
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
==========
thakis@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687323003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
Description was changed from
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
==========
to
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
NOTRY=true
==========
filed https://code.google.com/p/chromium/issues/detail?id=586120 for the broken android try bot
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687323003/1
Message was sent while issue was closed.
Description was changed from
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
NOTRY=true
==========
to
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
NOTRY=true
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Description was changed from
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
NOTRY=true
==========
to
==========
gn/win: Add a runtime_link_output to tool("solink")
See the CL description of https://codereview.chromium.org/1690843002/ for more.
BUG=354261, 498033
TBR=scottmg
NOTRY=true
Committed: https://crrev.com/4d1b63a0366d4590efd6c29d62d2308c4a2941c8
Cr-Commit-Position: refs/heads/master@{#374894}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4d1b63a0366d4590efd6c29d62d2308c4a2941c8 Cr-Commit-Position: refs/heads/master@{#374894} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
