Revert of [counters] moving runtime counters to counter.h

Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1 of https://codereview.chromium.org/1688783005/ )

Reason for revert:
failing gc-stress tests

Original issue's description:
> Reland of [counters] moving runtime counters to counter.h (patchset #1 id:1 of https://codereview.chromium.org/1681923003/ )
>
> Reason for revert:
> This CL was not the cause for the TSAN failures, the instruction-selector backend for x64 emitted  a wrong compare which accidentally showed up with tsan + code moves.
> The instruction-selectors changes have been reverted with https://codereview.chromium.org/1693433002
>
> Original issue's description:
> > Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1 of https://codereview.chromium.org/1678973002/ )
> >
> > Reason for revert:
> > [Sheriff] Breaks TSAN:
> > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7727
> >
> > Original issue's description:
> > > [counters] moving runtime counters to counter.h
> > >
> > > Additionally list C++ builtins as well under --runtime_call_stats.
> > > Let's try to keep all counters in one place, that makes it a bit
> > > easier to maintain and especially discard unused ones.
> > >
> > > BUG=
> > >
> > > Committed: https://crrev.com/6bc71431995d49d4ca4a2ea9c75e5add5f345225
> > > Cr-Commit-Position: refs/heads/master@{#33847}
> >
> > TBR=jarin@chromium.org,cbruni@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=
> >
> > Committed: https://crrev.com/2d669b96639517cfc33e6fc6d4c3814587bc7366
> > Cr-Commit-Position: refs/heads/master@{#33848}
>
> TBR=jarin@chromium.org,machenbach@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=
>
> Committed: https://crrev.com/ad943fe44ede22b90b871e1233334dff5ff545c3
> Cr-Commit-Position: refs/heads/master@{#33887}

TBR=jarin@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/bab059707ddc4ed5ca3f0ad76aa73859b276ed25
Cr-Commit-Position: refs/heads/master@{#33889}

[Camillo Bruni, 2016-02-11 11:56:04]

Created Revert of [counters] moving runtime counters to counter.h

[commit-bot: I haz the power, 2016-02-11 11:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687313002/1

[commit-bot: I haz the power, 2016-02-11 11:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687313002/1

[commit-bot: I haz the power, 2016-02-11 11:56:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-11 11:56:27]

Failed to apply patch for src/runtime/runtime.h:
While running git apply --index -3 -p1;
  error: patch failed: src/runtime/runtime.h:1206
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: src/runtime/runtime.h: patch does not apply

Patch:       src/runtime/runtime.h
Index: src/runtime/runtime.h
diff --git a/src/runtime/runtime.h b/src/runtime/runtime.h
index
b5bcedb83aa118cdc53c0a5e1615741978d48341..668021d876b086a60c7021d5b87bb38bcaa91e15
100644
--- a/src/runtime/runtime.h
+++ b/src/runtime/runtime.h
@@ -1188,6 +1188,26 @@
 };
 
 
+struct RuntimeCallStats {
+#define CALL_RUNTIME_COUNTER(name, nargs, ressize) \
+  uint32_t Count_Runtime_##name;                   \
+  base::TimeDelta Time_Runtime_##name;
+  FOR_EACH_INTRINSIC(CALL_RUNTIME_COUNTER)
+#undef CALL_RUNTIME_COUNTER
+
+  // Dummy counter for the unexpected stub miss.
+  uint32_t Count_UnexpectedStubMiss;
+  base::TimeDelta Time_UnexpectedStubMiss;
+
+  bool in_runtime_call = false;
+
+  void Reset();
+  void Print(std::ostream& os);
+
+  RuntimeCallStats() { Reset(); }
+};
+
+
 class RuntimeState {
  public:
   unibrow::Mapping<unibrow::ToUppercase, 128>* to_upper_mapping() {
@@ -1206,11 +1226,14 @@
     redirected_intrinsic_functions_.Reset(redirected_intrinsic_functions);
   }
 
+  RuntimeCallStats* runtime_call_stats() { return &runtime_call_stats_; }
+
  private:
   RuntimeState() {}
   unibrow::Mapping<unibrow::ToUppercase, 128> to_upper_mapping_;
   unibrow::Mapping<unibrow::ToLowercase, 128> to_lower_mapping_;
 
+  RuntimeCallStats runtime_call_stats_;
 
   base::SmartArrayPointer<Runtime::Function> redirected_intrinsic_functions_;

[commit-bot: I haz the power, 2016-02-11 11:56:52]

Description was changed from

==========
Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1 of
https://codereview.chromium.org/1688783005/ )

Reason for revert:
failing gc-stress tests

Original issue's description:
> Reland of [counters] moving runtime counters to counter.h (patchset #1 id:1 of
https://codereview.chromium.org/1681923003/ )
> 
> Reason for revert:
> This CL was not the cause for the TSAN failures, the instruction-selector
backend for x64 emitted  a wrong compare which accidentally showed up with tsan
+ code moves.
> The instruction-selectors changes have been reverted with
https://codereview.chromium.org/1693433002
> 
> Original issue's description:
> > Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1
of https://codereview.chromium.org/1678973002/ )
> >
> > Reason for revert:
> > [Sheriff] Breaks TSAN:
> >
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7727
> >
> > Original issue's description:
> > > [counters] moving runtime counters to counter.h
> > >
> > > Additionally list C++ builtins as well under --runtime_call_stats.
> > > Let's try to keep all counters in one place, that makes it a bit
> > > easier to maintain and especially discard unused ones.
> > >
> > > BUG=
> > >
> > > Committed: https://crrev.com/6bc71431995d49d4ca4a2ea9c75e5add5f345225
> > > Cr-Commit-Position: refs/heads/master@{#33847}
> >
> > TBR=jarin@chromium.org,cbruni@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=
> >
> > Committed: https://crrev.com/2d669b96639517cfc33e6fc6d4c3814587bc7366
> > Cr-Commit-Position: refs/heads/master@{#33848}
> 
> TBR=jarin@chromium.org,machenbach@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=
> 
> Committed: https://crrev.com/ad943fe44ede22b90b871e1233334dff5ff545c3
> Cr-Commit-Position: refs/heads/master@{#33887}

TBR=jarin@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1 of
https://codereview.chromium.org/1688783005/ )

Reason for revert:
failing gc-stress tests

Original issue's description:
> Reland of [counters] moving runtime counters to counter.h (patchset #1 id:1 of
https://codereview.chromium.org/1681923003/ )
>
> Reason for revert:
> This CL was not the cause for the TSAN failures, the instruction-selector
backend for x64 emitted  a wrong compare which accidentally showed up with tsan
+ code moves.
> The instruction-selectors changes have been reverted with
https://codereview.chromium.org/1693433002
>
> Original issue's description:
> > Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1
of https://codereview.chromium.org/1678973002/ )
> >
> > Reason for revert:
> > [Sheriff] Breaks TSAN:
> >
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7727
> >
> > Original issue's description:
> > > [counters] moving runtime counters to counter.h
> > >
> > > Additionally list C++ builtins as well under --runtime_call_stats.
> > > Let's try to keep all counters in one place, that makes it a bit
> > > easier to maintain and especially discard unused ones.
> > >
> > > BUG=
> > >
> > > Committed: https://crrev.com/6bc71431995d49d4ca4a2ea9c75e5add5f345225
> > > Cr-Commit-Position: refs/heads/master@{#33847}
> >
> > TBR=jarin@chromium.org,cbruni@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=
> >
> > Committed: https://crrev.com/2d669b96639517cfc33e6fc6d4c3814587bc7366
> > Cr-Commit-Position: refs/heads/master@{#33848}
>
> TBR=jarin@chromium.org,machenbach@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=
>
> Committed: https://crrev.com/ad943fe44ede22b90b871e1233334dff5ff545c3
> Cr-Commit-Position: refs/heads/master@{#33887}

TBR=jarin@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/bab059707ddc4ed5ca3f0ad76aa73859b276ed25
Cr-Commit-Position: refs/heads/master@{#33889}
==========

[commit-bot: I haz the power, 2016-02-11 11:56:53]

Patchset 1 (id:??) landed as
https://crrev.com/bab059707ddc4ed5ca3f0ad76aa73859b276ed25
Cr-Commit-Position: refs/heads/master@{#33889}