Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 1687283003: fix warnings/test failures due to analyzer warnings, update stauts to include (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
index e2c86da1575cd2cd4cbd1c12565a32847fdffa4a..8ec5743eca62b7a85efaec5a0e2462d129b0d733 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
@@ -21,6 +21,7 @@ import '../io/source_information.dart';
import '../js/js.dart' as js show
js,
objectLiteral,
+ Expression,
LiteralStatement,
Template,
InterpolatedExpression,
@@ -2072,7 +2073,7 @@ class IrBuilder {
}
static _isNotNull(ir.Primitive value) =>
- value is! ir.Constant || !value.value.isNull;
+ !(value is ir.Constant && value.value.isNull);
/// Builds a call to a resolved js-interop element.
ir.Primitive buildInvokeJsInteropMember(FunctionElement element,
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698