Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: media/audio/audio_input_device.cc

Issue 1687213002: Express audio delay more precisely in frames rather than milliseconds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_input_device.cc
diff --git a/media/audio/audio_input_device.cc b/media/audio/audio_input_device.cc
index 52017f248a3580661d2ba4dd4c0e76797f8ff49c..f5e9ae6c635765139e43a579cb9e15b47bb7ef00 100644
--- a/media/audio/audio_input_device.cc
+++ b/media/audio/audio_input_device.cc
@@ -340,8 +340,7 @@ void AudioInputDevice::AudioThreadCallback::Process(uint32_t pending_data) {
capture_callback_->Capture(
audio_bus,
buffer->params.hardware_delay_bytes / bytes_per_ms_, // Delay in ms
chcunningham 2016/02/11 01:25:42 Another API expecing msec. Everyone OK to change t
Henrik Grunell 2016/02/12 17:47:01 sgtm
chcunningham 2016/02/17 01:56:51 Filed 587291. Added comment.
- buffer->params.volume,
- buffer->params.key_pressed);
+ buffer->params.volume, buffer->params.key_pressed);
if (++current_segment_id_ >= total_segments_)
current_segment_id_ = 0;

Powered by Google App Engine
This is Rietveld 408576698