content/renderer/media/renderer_webaudiodevice_impl.cc - Issue 1687213002: Express audio delay more precisely in frames rather than milliseconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_webaudiodevice_impl.cc

Issue 1687213002: Express audio delay more precisely in frames rather than milliseconds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/renderer_webaudiodevice_impl.h ('k') | content/renderer/media/track_audio_renderer.h » ('j') | content/renderer/media/webrtc_audio_renderer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_webaudiodevice_impl.cc

diff --git a/content/renderer/media/renderer_webaudiodevice_impl.cc b/content/renderer/media/renderer_webaudiodevice_impl.cc

index 6c366c1f71777690f71c0becb3ec59d80d402f92..6088a069182a7aa9903ba80746e32d483057d269 100644

--- a/content/renderer/media/renderer_webaudiodevice_impl.cc

+++ b/content/renderer/media/renderer_webaudiodevice_impl.cc

@@ -100,7 +100,7 @@ double RendererWebAudioDeviceImpl::sampleRate() {

}

int RendererWebAudioDeviceImpl::Render(media::AudioBus* dest,

- uint32_t audio_delay_milliseconds,

+ uint32_t frames_delayed,

chcunningham 2016/02/11 01:25:42 This method isn't making use of delay... should it

chcunningham 2016/02/11 21:02:52 @dale, your thoughts?

DaleCurtis 2016/02/11 21:04:19 Oh didn't realize that question was for me. +rtoy

uint32_t frames_skipped) {

#if defined(OS_ANDROID)

if (is_first_buffer_after_silence_) {