Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: media/base/audio_capturer_source.h

Issue 1687213002: Express audio delay more precisely in frames rather than milliseconds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_parameters.cc ('k') | media/base/audio_renderer_mixer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_capturer_source.h
diff --git a/media/base/audio_capturer_source.h b/media/base/audio_capturer_source.h
index 31b39bbf993f6367d4bfd1378426698155b286d0..fd79db3dfcd7f4ccfe3c9e711b51863dd97b133d 100644
--- a/media/base/audio_capturer_source.h
+++ b/media/base/audio_capturer_source.h
@@ -23,6 +23,8 @@ class AudioCapturerSource
class CaptureCallback {
public:
// Callback to deliver the captured data from the OS.
+ // TODO(chcunningham): Update delay argument to use frames instead of
+ // milliseconds to prevent loss of precision. See http://crbug.com/587291.
virtual void Capture(const AudioBus* audio_source,
int audio_delay_milliseconds,
double volume,
« no previous file with comments | « media/audio/audio_parameters.cc ('k') | media/base/audio_renderer_mixer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698