MIPS: Fix '[runtime] Optimize and unify rest parameters.'

MIPS: Fix '[runtime] Optimize and unify rest parameters.'

Fixes a register-clobbering problem. The Branch() instruction can overwrite the 'at' register, so it can't be used as scratch in Allocate(). Added DCHECK to avoid this in the future.

BUG=

Committed: https://crrev.com/b44bea94f9beb24dbd39d9b7e8c9c16ca3a4adf8
Cr-Commit-Position: refs/heads/master@{#33912}

[akos.palfi.imgtec, 2016-02-11 16:55:57]

Description was changed from

==========
MIPS: Fix '[runtime] Optimize and unify rest parameters.'

BUG=
==========

to

==========
MIPS: Fix '[runtime] Optimize and unify rest parameters.'

Fixes a register-clobbering problem. The Branch() instruction can overwrite the
'at' register, so it can't be used as scratch in Allocate(). Added DCHECK to
avoid this in the future.

BUG=
==========

[akos.palfi.imgtec, 2016-02-11 16:58:21]

akos.palfi@imgtec.com changed reviewers:
+ balazs.kilvady@imgtec.com, bmeurer@chromium.org, gergely.kis@imgtec.com,
ivica.bogosavljevic@imgtec.com

[akos.palfi.imgtec, 2016-02-11 16:58:21]

PTAL.

[balazs.kilvady, 2016-02-11 17:07:49]

LGTM with a nit.

https://codereview.chromium.org/1687173006/diff/1/src/mips64/code-stubs-mips6...
File src/mips64/code-stubs-mips64.cc (right):

https://codereview.chromium.org/1687173006/diff/1/src/mips64/code-stubs-mips6...
src/mips64/code-stubs-mips64.cc:5261: __ Allocate(a1, v0, a3, t0, &allocate,
TAG_OBJECT);
I think a4 should be used instead of t0 on MIPS64.

[akos.palfi.imgtec, 2016-02-11 17:16:19]

The CQ bit was checked by akos.palfi@imgtec.com

[akos.palfi.imgtec, 2016-02-11 17:16:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
balazs.kilvady@imgtec.com
Link to the patchset: https://codereview.chromium.org/1687173006/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-02-11 17:16:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1687173006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1687173006/20001

[commit-bot: I haz the power, 2016-02-11 17:42:19]

Description was changed from

==========
MIPS: Fix '[runtime] Optimize and unify rest parameters.'

Fixes a register-clobbering problem. The Branch() instruction can overwrite the
'at' register, so it can't be used as scratch in Allocate(). Added DCHECK to
avoid this in the future.

BUG=
==========

to

==========
MIPS: Fix '[runtime] Optimize and unify rest parameters.'

Fixes a register-clobbering problem. The Branch() instruction can overwrite the
'at' register, so it can't be used as scratch in Allocate(). Added DCHECK to
avoid this in the future.

BUG=
==========

[commit-bot: I haz the power, 2016-02-11 17:42:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-11 17:42:49]

Description was changed from

==========
MIPS: Fix '[runtime] Optimize and unify rest parameters.'

Fixes a register-clobbering problem. The Branch() instruction can overwrite the
'at' register, so it can't be used as scratch in Allocate(). Added DCHECK to
avoid this in the future.

BUG=
==========

to

==========
MIPS: Fix '[runtime] Optimize and unify rest parameters.'

Fixes a register-clobbering problem. The Branch() instruction can overwrite the
'at' register, so it can't be used as scratch in Allocate(). Added DCHECK to
avoid this in the future.

BUG=

Committed: https://crrev.com/b44bea94f9beb24dbd39d9b7e8c9c16ca3a4adf8
Cr-Commit-Position: refs/heads/master@{#33912}
==========

[commit-bot: I haz the power, 2016-02-11 17:42:50]

Patchset 2 (id:??) landed as
https://crrev.com/b44bea94f9beb24dbd39d9b7e8c9c16ca3a4adf8
Cr-Commit-Position: refs/heads/master@{#33912}