Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1687143002: Remove calls to MediaCodec#stop from AVDA (Closed)

Created:
4 years, 10 months ago by watk
Modified:
4 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MediaCodec#stop from AVDA Previously there were cases where MediaCodec#stop would be called while the MediaCodec was in a broken state, which results in hitting a CHECK. In AVDA we don't actually need to call stop() because it's always called right before deleting the MediaCodec. This replaces those calls with explicit deletion. BUG=582275 TEST=Trying to play videos with unsupported profiles; no crashes Committed: https://crrev.com/1315ac0838d78f1fcc1dcc9836bf8795857d9a8e Cr-Commit-Position: refs/heads/master@{#374754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/common/gpu/media/android_video_decode_accelerator.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
watk
4 years, 10 months ago (2016-02-10 21:04:31 UTC) #2
DaleCurtis
lgtm
4 years, 10 months ago (2016-02-10 21:08:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687143002/1
4 years, 10 months ago (2016-02-10 21:14:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 22:39:36 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1315ac0838d78f1fcc1dcc9836bf8795857d9a8e
Cr-Commit-Position: refs/heads/master@{#374754}

Powered by Google App Engine
This is Rietveld 408576698