Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2446)

Unified Diff: cc/trees/layer_tree_host_unittest_delegated.cc

Issue 16871016: cc: Use BeginFrameArgs (Closed) Base URL: http://git.chromium.org/chromium/src.git@bfargs2
Patch Set: Improve main thread perf by pushing out deadline if no Impl updates. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest_delegated.cc
diff --git a/cc/trees/layer_tree_host_unittest_delegated.cc b/cc/trees/layer_tree_host_unittest_delegated.cc
index 08ba3e061075f35873acfc1cace62392ac375f31..de5f3e0adb3504ea12899b1a9178b4b9aac8f86b 100644
--- a/cc/trees/layer_tree_host_unittest_delegated.cc
+++ b/cc/trees/layer_tree_host_unittest_delegated.cc
@@ -155,19 +155,15 @@ class LayerTreeHostDelegatedTestCreateChildId
host_impl->resource_provider()->GraphicsContext3D();
++num_activates_;
- switch (num_activates_) {
- case 2:
+ if (num_activates_ == 2) {
EXPECT_TRUE(delegated_impl->ChildId());
EXPECT_FALSE(did_reset_child_id_);
context->loseContextCHROMIUM(GL_GUILTY_CONTEXT_RESET_ARB,
GL_INNOCENT_CONTEXT_RESET_ARB);
- break;
- case 3:
+ } else if (did_reset_child_id_) {
enne (OOO) 2013/08/15 19:47:59 I'm not sure I understand the changes to this test
brianderson 2013/08/15 23:05:10 I made changes to the Scheduler's behavior when we
enne (OOO) 2013/08/16 00:53:22 Ah, ok. This is that new aborted draw case. Than
EXPECT_TRUE(delegated_impl->ChildId());
- EXPECT_TRUE(did_reset_child_id_);
EndTest();
- break;
}
}
@@ -182,7 +178,7 @@ class LayerTreeHostDelegatedTestCreateChildId
FakeDelegatedRendererLayerImpl* delegated_impl =
static_cast<FakeDelegatedRendererLayerImpl*>(root_impl->children()[0]);
- EXPECT_EQ(2, num_activates_);
+ EXPECT_LE(2, num_activates_);
EXPECT_FALSE(delegated_impl->ChildId());
did_reset_child_id_ = true;
}

Powered by Google App Engine
This is Rietveld 408576698