cc: Use BeginFrameArgs

cc/trees/thread_proxy.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/thread_proxy.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 1027 matching lines @@
   return ScheduledActionDrawAndSwapInternal(true);
 }
 
 void ThreadProxy::DidAnticipatedDrawTimeChange(base::TimeTicks time) {
   if (current_resource_update_controller_on_impl_thread_)
     current_resource_update_controller_on_impl_thread_
         ->PerformMoreUpdates(time);
   layer_tree_host_impl_->ResetCurrentFrameTimeForNextFrame();
 }
 
+
+void ThreadProxy::PostBeginFrameDeadlineTask(base::TimeTicks deadline) {
+  base::TimeDelta delta = deadline - base::TimeTicks::Now();

[ajuma, 2013/06/14 15:22:32]

To get a sufficiently precise delta on Windows, we'll need HighResNow() (also
when calculating the deadline itself).

[brianderson, 2013/06/14 18:42:36]

Ok. We'll have to be very careful about comparing HighResNow() and Now().
@simonjam mentioned that base::TimeTicks makes an attempt to keep them
comparable, but I'm not sure we can trust it.

Also, HighResNow doesn't work very well on some old Windows+CPU+driver
combinations - the result isn't monotonically increasing if called on different
cores.

+  if (delta <= base::TimeDelta()) {
+    scheduler_on_impl_thread_->OnBeginFrameDeadline();
+    return;
+  }
+
+  Proxy::ImplThread()->PostDelayedTask(

[Sami, 2013/06/14 15:59:20]

Can/should we cancel this task if we drew before the deadline?

[brianderson, 2013/06/14 18:42:36]

It's kind of "canceled" manually based on the begin_frame_state_. Is there a way
to cancel it so that it doesn't even wake up the thread?

+      base::Bind(&ThreadProxy::OnBeginFrameDeadline,
+                 weak_factory_on_impl_thread_.GetWeakPtr()),
+      deadline - base::TimeTicks::Now());

[ajuma, 2013/06/14 15:22:32]

We can reuse |delta| here.

[brianderson, 2013/06/14 18:42:36]

oops!

+}
+
+void ThreadProxy::OnBeginFrameDeadline() {
+  DCHECK(IsImplThread());
+  scheduler_on_impl_thread_->OnBeginFrameDeadline();
+}
+
 void ThreadProxy::ReadyToFinalizeTextureUpdates() {
   DCHECK(IsImplThread());
   scheduler_on_impl_thread_->FinishCommit();
 }
 
 void ThreadProxy::DidCommitAndDrawFrame() {
   DCHECK(IsMainThread());
   if (!layer_tree_host_)
     return;
   layer_tree_host_->DidCommitAndDrawFrame();
@@ skipping 318 matching lines @@
       !layer_tree_host_impl_->pending_tree()) {
     TRACE_EVENT_INSTANT0("cc", "ReleaseCommitbyActivation",
                          TRACE_EVENT_SCOPE_THREAD);
     DCHECK(layer_tree_host_impl_->settings().impl_side_painting);
     completion_event_for_commit_held_on_tree_activation_->Signal();
     completion_event_for_commit_held_on_tree_activation_ = NULL;
   }
 }
 
 }  // namespace cc