cc: Use BeginFrameArgs

cc/scheduler/scheduler_state_machine.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SCHEDULER_SCHEDULER_STATE_MACHINE_H_
 #define CC_SCHEDULER_SCHEDULER_STATE_MACHINE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 13 matching lines @@
 // requested, while external state includes things like the current time being
 // near to the vblank time.
 //
 // The scheduler seperates "what to do next" from the updating of its internal
 // state to make testing cleaner.
 class CC_EXPORT SchedulerStateMachine {
  public:
   // settings must be valid for the lifetime of this class.
   explicit SchedulerStateMachine(const SchedulerSettings& settings);
 
+  enum BeginFrameState {
+    BEGIN_FRAME_IDLE,
+    BEGIN_FRAME_STARTING,
+    BEGIN_FRAME_WAITING,
+    BEGIN_FRAME_DRAWING,
+  };
+
   enum CommitState {
     COMMIT_STATE_IDLE,
     COMMIT_STATE_FRAME_IN_PROGRESS,
     COMMIT_STATE_READY_TO_COMMIT,
     COMMIT_STATE_WAITING_FOR_FIRST_DRAW,
     COMMIT_STATE_WAITING_FOR_FIRST_FORCED_DRAW,
   };
 
   enum TextureState {
     LAYER_TEXTURE_STATE_UNLOCKED,
@@ skipping 28 matching lines @@
   Action NextAction() const;
   void UpdateState(Action action);
 
   // Indicates whether the main thread needs a begin frame callback in order to
   // make progress.
   bool BeginFrameNeededByImplThread() const;
 
   // Indicates that the system has entered and left a BeginFrame callback.
   // The scheduler will not draw more than once in a given BeginFrame
   // callback.
-  void DidEnterBeginFrame(BeginFrameArgs args);
-  void DidLeaveBeginFrame();
-  bool inside_begin_frame() const { return inside_begin_frame_; }
+  void StartBeginFrame(BeginFrameArgs args);

[Sami, 2013/06/14 15:59:20]

bikeshed: StartBeginFrame sounds weird :) How about just OnBeginFrame or
DidBeginFrame?

[brianderson, 2013/06/14 18:42:36]

OnBeginFrame sounds good.

+  void OnBeginFrameDeadline();
+  BeginFrameState begin_frame_state() const { return begin_frame_state_; }
 
   // Indicates whether the LayerTreeHostImpl is visible.
   void SetVisible(bool visible);
 
   // Indicates that a redraw is required, either due to the impl tree changing
   // or the screen being damaged and simply needing redisplay.
   void SetNeedsRedraw();
 
   // As SetNeedsRedraw(), but ensures the draw will definitely happen even if
   // we are not visible.
@@ skipping 72 matching lines @@
   bool HasDrawnThisFrame() const;
   bool HasAttemptedTreeActivationThisFrame() const;
   bool HasCheckedForCompletedTileUploadsThisFrame() const;
 
   const SchedulerSettings settings_;
 
   CommitState commit_state_;
   int commit_count_;
 
   int current_frame_number_;
-  int last_frame_number_where_draw_was_called_;
-  int last_frame_number_where_tree_activation_attempted_;
-  int last_frame_number_where_check_for_completed_tile_uploads_called_;
+  int current_frame_attempt_;

[brianderson, 2013/06/14 04:16:29]

current_frame_attempt_ allows us to reset the last_frame_attempt* variables
because we want to check some things multiple times per frame (begin frame
start, pending tree activation, and deadline).

+  int last_frame_attempt_draw_was_called_;
+  int last_frame_attempt_tree_activation_attempted_;
+  int last_frame_attempt_check_for_completed_tile_uploads_called_;
   int consecutive_failed_draws_;
   int maximum_number_of_failed_draws_before_draw_is_forced_;
   bool needs_redraw_;
   bool swap_used_incomplete_tile_;
   bool needs_forced_redraw_;
   bool needs_forced_redraw_after_next_commit_;
   bool needs_commit_;
   bool needs_forced_commit_;
   bool expect_immediate_begin_frame_for_main_thread_;
   bool main_thread_needs_layer_textures_;
-  bool inside_begin_frame_;
+  BeginFrameState begin_frame_state_;
+  bool active_tree_has_been_drawn_;
   BeginFrameArgs last_begin_frame_args_;
   bool visible_;
   bool can_start_;
   bool can_draw_;
   bool has_pending_tree_;
   bool draw_if_possible_failed_;
   TextureState texture_state_;
   OutputSurfaceState output_surface_state_;
   bool did_create_and_initialize_first_output_surface_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SchedulerStateMachine);
 };
 
 }  // namespace cc
 
 #endif  // CC_SCHEDULER_SCHEDULER_STATE_MACHINE_H_