Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1687093002: [mojo-edk] Bring most tests back up on Android (Closed)

Created:
4 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Bring most tests back up on Android Broken multiprocess tests were bringing down the whole mojo_system_unittests suite. These should be disabled on Android for now since our test runner simply does not have the ability to launch a child process at the moment. This CL disables all existing multiprocess tests for Android, but turns everything else back on. BUG=585784, 585849 TBR=amistry@chromium.org Committed: https://crrev.com/5602ed3039ea95e049b4729ea3bb2b3b660974c5 Cr-Commit-Position: refs/heads/master@{#374693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -37 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +13 lines, -20 lines 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 12 chunks +90 lines, -12 lines 0 comments Download
M mojo/edk/system/shared_buffer_unittest.cc View 4 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
4 years, 10 months ago (2016-02-10 18:10:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687093002/1
4 years, 10 months ago (2016-02-10 18:11:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 18:48:57 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 18:51:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5602ed3039ea95e049b4729ea3bb2b3b660974c5
Cr-Commit-Position: refs/heads/master@{#374693}

Powered by Google App Engine
This is Rietveld 408576698