Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1687053002: Consolidate strings in summary output. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Consolidate strings in summary output. This reduces the size of the SDK summary by about 15.5%. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8d130d1e093618f5fd78772e79b75b3ff977a25f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 2 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-10 17:18:14 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-10 17:19:27 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-10 17:25:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d130d1e093618f5fd78772e79b75b3ff977a25f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698