Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1687023002: Fix MojoTest by having it build a dist.jar (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
hartmanng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MojoTest by having it build a dist.jar Seems to be a special case where it's run as an instrumentation test but doesn't have an apk_under_test. This was broken by: https://codereview.chromium.org/1679623002/ TBR=hartmanng NOTRY=true BUG=585806 Committed: https://crrev.com/a5d36dd94c82353163da2fe4b54f217875a9b862 Cr-Commit-Position: refs/heads/master@{#374663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687023002/1
4 years, 10 months ago (2016-02-10 15:41:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 15:48:39 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 15:49:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5d36dd94c82353163da2fe4b54f217875a9b862
Cr-Commit-Position: refs/heads/master@{#374663}

Powered by Google App Engine
This is Rietveld 408576698