Switch database/file_identifier to std::string, remove createFromDatabaseIdentifier calls

content/browser/indexed_db/webidbfactory_impl.cc

Index: content/browser/indexed_db/webidbfactory_impl.cc
diff --git a/content/browser/indexed_db/webidbfactory_impl.cc b/content/browser/indexed_db/webidbfactory_impl.cc
index 17f646601466393fd797f0c57de6d2ba225af3ff..973fcc42cc3a0f6776a24bf2ea1c31e856ed9e36 100644
--- a/content/browser/indexed_db/webidbfactory_impl.cc
+++ b/content/browser/indexed_db/webidbfactory_impl.cc
@@ -8,6 +8,7 @@
 #include "content/browser/indexed_db/indexed_db_callbacks_wrapper.h"
 #include "content/browser/indexed_db/indexed_db_factory.h"
 #include "content/browser/indexed_db/indexed_db_factory.h"
+#include "third_party/WebKit/public/platform/WebCString.h"
 #include "third_party/WebKit/public/platform/WebIDBDatabaseError.h"
 #include "webkit/base/file_path_string_conversions.h"
 
@@ -25,7 +26,7 @@ void WebIDBFactoryImpl::getDatabaseNames(IndexedDBCallbacksBase* callbacks,
                                          const WebString& data_dir) {
   idb_factory_backend_->GetDatabaseNames(
       IndexedDBCallbacksWrapper::Create(callbacks),
-      database_identifier,
+      database_identifier.utf8(),

[jsbell, 2013/06/20 16:38:40]

Despite the name, these WebIDB*Impl files no longer implement WebIDB interfaces
- they're non-refcounted wrappers around refcounted objects. We'll refactor them
away soon.

So the signature on these can change, and they don't need to take WebStrings in.
We can push the conversion one level higher up into the caller
(IndexedDBDispatcherHost) if desired.

[jamesr, 2013/06/20 16:54:32]

In fact, it looks like the caller is taking a std::string and calling
WebString::fromUTF8() to generate this value.  Will nuke!

       webkit_base::WebStringToFilePath(data_dir));
 }
 
@@ -47,7 +48,7 @@ void WebIDBFactoryImpl::open(const WebString& name,
                              transaction_id,
                              callbacks_proxy.get(),
                              database_callbacks_proxy.get(),
-                             database_identifier,
+                             database_identifier.utf8(),
                              webkit_base::WebStringToFilePath(data_dir));
 }
 
@@ -58,7 +59,7 @@ void WebIDBFactoryImpl::deleteDatabase(const WebString& name,
   idb_factory_backend_->DeleteDatabase(
       name,
       IndexedDBCallbacksWrapper::Create(callbacks),
-      database_identifier,
+      database_identifier.utf8(),
       webkit_base::WebStringToFilePath(data_dir));
 }