Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 16870004: [sync] Force gaia re-auth on CrOs during sign in after changing password (Closed)

Created:
7 years, 6 months ago by Raghu Simha
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[sync] Force gaia re-auth on CrOs during sign in after changing password On Chrome OS, when we detect that a user's gaia password has changed, we prompt the user to sign out and sign in again via a link on the settings page. The first time the user signs out and back in, we do a local account re-auth instead of a full-fledged gaia re-auth. As a result, we continue to use an old OAuth2 token, and this requires the user to sign out and sign in yet again before the token is refreshed. This patch adds code that invalidates the existing OAuth2 token during the first sign out, so that the user is forced to do a full-fledged gaia-reauth during the first subsequent sign in, and thereby gets a fresh OAuth2 token. TBR=xiyuan@chromium.org, zelidrag@chromium.org BUG=234164 TEST=Sign in, change gaia password, click "Sign out and sign in", and make sure you go through a gaia re-auth the first time Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206203

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/webui/sync_setup_handler.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raghu Simha
Roger / Zel, please review. Thanks.
7 years, 6 months ago (2013-06-13 22:23:18 UTC) #1
xiyuan
LGTM
7 years, 6 months ago (2013-06-13 22:59:09 UTC) #2
zel
lgtm
7 years, 6 months ago (2013-06-13 23:00:30 UTC) #3
Raghu Simha
Committed patchset #1 manually as r206203 (presubmit successful).
7 years, 6 months ago (2013-06-13 23:15:56 UTC) #4
Nikita (slow)
7 years, 6 months ago (2013-06-14 17:59:02 UTC) #5
Message was sent while issue was closed.
lgtm

There's also item in hotdog menu that is shown on sync error and does sign out.

Powered by Google App Engine
This is Rietveld 408576698