Issue 16870002: Update SkBitmap::validate to respect Android flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16870002: Update SkBitmap::validate to respect Android flag. (Closed)

Created:
7 years, 6 months ago by scroggo

Modified:
7 years, 6 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Update SkBitmap::validate to respect Android flag. Without this change, an SkBitmap with hardware mip will assert in validate. R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9614

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/core/SkBitmap.cpp	View		1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

scroggo

Derek, does Android use this flag? I would expect them to crash if they run ...

7 years, 6 months ago (2013-06-12 21:58:43 UTC) #1

djsollen

On 2013/06/12 21:58:43, scroggo wrote: > Derek, does Android use this flag? I would expect ...

7 years, 6 months ago (2013-06-13 12:31:51 UTC) #2

scroggo

7 years, 6 months ago (2013-06-14 15:56:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r9614 (presubmit successful).